Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to configure client target #3349

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

taraktikos
Copy link
Contributor

@taraktikos taraktikos commented Oct 31, 2024

The graphql client gqlgen provides for testing is hardcoded to use / as the target.
The target is the RFC 7230 "request-target": it may be either a path or an absolute URL.
This PR retains/ as the default target, but provides a customization option to pick an alternative target.

Describe your PR and link to any relevant issues:

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@StevenACoffman StevenACoffman added the client GraphQL Client related label Oct 31, 2024
@coveralls
Copy link

Coverage Status

coverage: 59.206% (-0.04%) from 59.248%
when pulling fd6112e on taraktikos:patch-1
into b336eae on 99designs:master.

@StevenACoffman StevenACoffman merged commit 0b86cf7 into 99designs:master Oct 31, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks! The humble testing client doesn't get a lot of love. I appreciate the PR, and look forward to your next!

@taraktikos
Copy link
Contributor Author

taraktikos commented Oct 31, 2024

Thanks! The humble testing client doesn't get a lot of love. I appreciate the PR, and look forward to your next!

The test was in progress :) Here it is #3350
Thank you for quick reaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client GraphQL Client related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants