Update safire.py #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed config.py path issue
Simplified so config.py is created with default_config.py, no need to instruct user to download default_config.py when it's already there.
Changed svcaccts generation to create guaranteed unique filenames using the project name and the service account id: <project>@<private_key_id>.json Multiple projects/service accounts no longer overwrite one another if script run at separate times. No need for next_json_num
Just realised service account jsons are not unique, reverted to something a little different what it was originally. <project>@<next_json_num>.json With each project next_json_num reverts to 1 Easier to identify what credentials belong to which project this way.
def_cfg_file pointed to wrong directory, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed config.py path issue
#3