Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error appears when configuring VM while 86Box path is invalid #60

Closed
digitalec opened this issue Aug 24, 2019 · 2 comments
Closed

Incorrect error appears when configuring VM while 86Box path is invalid #60

digitalec opened this issue Aug 24, 2019 · 2 comments
Assignees
@daviunic
Labels
enhancement New feature or request

Comments

@digitalec
Copy link

If the path to 86Box isn't correct and you try to configure a VM, it'll produce an error stating "This virtual machine could not be started." followed by an Exception message:

86Man

I realized after going through Settings that 86BoxManager uses a path to locate 86Box rather than just being in the same directory (I had unzipped the two into a desktop folder). It would be beneficial to new users to either 1) update this error to match the same error displayed when trying to start a VM ("Cannot find 86Box.exe. Make sure your settings are correct and try again.") or 2) you could also check if 86Box.exe exists in C:\Program Files (x86)\86Box\ and then set the path as such otherwise prompt the user for it's location on startup.
@daviunic daviunic self-assigned this Aug 24, 2019
@daviunic daviunic added the enhancement New feature or request label Aug 24, 2019
@daviunic
Copy link
Contributor

I'll update the error message to match the one for starting a VM.

@daviunic
Copy link
Contributor

The error message has been changed in 1.5.4.

daviunic added a commit that referenced this issue Aug 24, 2019
@daviunic
Version 1.5.4
f76f58a 
Fixed issue #61
Reworked the settings code a bit again to fix issue #62
Change the error dialog for VM configure when 86Box.exe can't be found from issue #60
Resetting the settings to default values no longer automatically saves them
notBald pushed a commit to notBald/Avalonia86 that referenced this issue Jan 7, 2025
@daviunic
Version 1.5.4
f40a50f 
Fixed issue 86Box#61
Reworked the settings code a bit again to fix issue 86Box#62
Change the error dialog for VM configure when 86Box.exe can't be found from issue 86Box#60
Resetting the settings to default values no longer automatically saves them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviunic daviunic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digitalec @daviunic