fix(cli): set serviceResponse default value to body #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set this so the default request file will return the body of the request instead of the whole response object. This changed at some point in the underlying library, so we need to update our default value to match.
Coverage Report
File CoverageNo changed files found. |
Collaborator
Author
|
npm publish |
7nohe
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set this so that the default request file returns the request's body instead of the whole response object.
This changed in the underlying library at some point, so we must update our default value to match.
fixes: #95
As this library relies on the response being the body, maybe we should think of disabling allowing consumers to change that option. Something to think about.