This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Fixed: date parse error when opening calendar with "special" date format string #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n day, month or year, the date wasn’t parsed correctly in other languages when opening the calendar. For instance the format `EEE dd.MM.yyyy` wasn’t parsed correctly.
45kb
added a commit
that referenced
this pull request
Jun 7, 2017
|
Thanks @adrianhara it's released with the new v2.1.20 version of the module https://github.com/720kb/angular-datepicker/releases/tag/2.1.20 |
|
Wow, that was fast! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the
date-formatstring included other specifiers than day, month or year, the date wasn't parsed correctly in other languages when opening the calendar. For instance the formatEEE dd.MM.yyyywasn’t parsed correctly. This was due to the fact that thelocalDateTimestampfunction only looked for specifiers for day, month and year and in case other specifiers existed it wouldn't ignore them, thereby messing up its lookup index in the date string.The fix basically ignores other specifiers and looks up the day, month and year in the input string correctly.