Invalid date pickup for locale date format

[bender404]

If language local date format has different order like standard
"English", then selection in popup calendar get invalid date. For
example, Czech or Slovak date format start with day number (dd.MM.yy).
If date format not start with month number, then new Date() parse
invalid date or if day number is not bigger then 12, switch day and
month

[45kb]

hi @bender404 thanks for this!

Have you tried this with different locales?
What if i am using angular i18n https://docs.angularjs.org/guide/i18n does this works?
We use angular $filter('date') cause you may want to use the angular i18n files...

Also, please do not include console.log and be sure to run npm run lint to check linter errors ;)

[bender404]

Hi @45kb thanks for your feedback.

$filter('date') "just" format Date() object to simple text string. If can "back way", $filter('date') not help me. Because what really parse text string to Date() object is native JS. Native parser Date(string)
expects English date format. So this https://github.com/720kb/angular-datepicker/blob/master/src/js/angular-datepicker.js#L623 not work properly, if locale format is't likeness as in English.

Also not work properly if date format use non-english month name.

[45kb]

@bender404 thanks for linting the code!

Actually the only thing that blocks me to merge this is that i don't have the time to test it properly, can you please make some tests if you have not already?

Would be to:

• test on all major browsers (CH, FF, OP, SF, IE 9+) for possible incompatibility and/or possible errors/warnings

• test with different locales (setting up different PC timezone should be enough to switch locale on the browser)

• test with different locales and different Angular i18n files

• be absolutely sure that there is no angular way to achieve the same (i.e: in angular we are supposed to use angular.forEach instead of for() 😛 )

[bender404]

Hi @45kb

Native for() is much faster like a angular.forEach() (test on jspref - 90% difference). Second reason is angular.forEach() don't have break;. Last reason, current code also contain for() loop. So I still use for() loop, I think is better.

All major browsers, different locales and timezone with last commit is OK.

[45kb]

@bender404 hey, thanks i will merge this and release a new version of the module asap! thank you a lot.

[45kb]

@bender404 what happened? i see you closed this but it was ok, i was going to merge it

[bender404]

Sorry is my mistake.

[45kb]

@bender404 no problems! thanks for the PR it's now shipped withthe new v2.1.14 👍