Fix app-wallet add-account flow.

[prxt6529]

Summary by CodeRabbit

• Tests

  • Added comprehensive tests covering the add-account flow across wallet connector types and scenarios, asserting disconnect/open behavior, retry logic, and interactions across rerenders and repeated clicks.

• Bug Fixes

  • Improved add-account flow to detect and prevent stale/duplicate attempts, distinguish app-wallet vs browser-wallet flows, and ensure correct disconnect vs direct-connect behavior with proper retry/timing handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 565e1f22-a62c-462a-b34c-1dcf79bae3e5

📥 Commits

Reviewing files that changed from the base of the PR and between d9da870 and 96632c0.

📒 Files selected for processing (1)

• __tests__/components/auth/SeizeConnectContext.addAccount.test.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/components/auth/SeizeConnectContext.addAccount.test.tsx

---

📝 Walkthrough

Walkthrough

Refactors the add-account control flow in SeizeConnectProvider to detect stale/duplicate add attempts, bypass disconnect+retry for app-wallet connectors, and wires Wagmi useAccount() for connector type detection; adds a comprehensive Jest/RTL test suite covering the new behaviors and edge cases.

Changes

Cohort / File(s)	Summary
Test Suite __tests__/components/auth/SeizeConnectContext.addAccount.test.tsx	New Jest + React Testing Library tests exercising seizeAddConnectedAccount under SeizeConnectProvider, mocking AppKit/Wagmi/hooks and asserting disconnect/open call sequences across app-wallet, browser-wallet, stale-flow, and no-live-wallet scenarios.
Add-Account Flow Logic components/auth/SeizeConnectContext.tsx	Added useAccount() to detect connector.type and isActiveAppWalletConnector; refactored seizeAddConnectedAccount to remove prior early-return guard, add stale/duplicate-attempt detection, introduce bypass for app-wallet or no-live-wallet (skip disconnect()), preserve disconnect+retry for other cases, and update hook dependencies.

Sequence Diagram

sequenceDiagram
    participant User
    participant SeizeConnect as SeizeConnectProvider
    participant Wagmi
    participant AppKit

    User->>SeizeConnect: Click "Add Account" (seizeAddConnectedAccount)
    activate SeizeConnect

    SeizeConnect->>Wagmi: useAccount() → connector.type?
    Wagmi-->>SeizeConnect: connector.type

    alt App-wallet connector or no live connected wallet
        SeizeConnect->>AppKit: open({ view: "Connect" })
        Note over SeizeConnect: Bypass disconnect+retry
    else Browser-wallet connector with potential stale flow
        SeizeConnect->>SeizeConnect: detect stale/duplicate attempt?
        alt Stale detected
            SeizeConnect->>AppKit: disconnect()
            SeizeConnect->>SeizeConnect: set retry timeout / gating
            SeizeConnect->>AppKit: open({ view: "Connect" }) after retry
        else Fresh flow
            SeizeConnect->>AppKit: open({ view: "Connect" })
        end
    end

    deactivate SeizeConnect
    AppKit-->>User: Present connection UI

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• Fix account switch sync thrash #2056: Modifies seizeAddConnectedAccount flow, stale-guard handling, and connector-type logic—strongly related.

Suggested reviewers

• ragnep

Poem

🐰
I hop where connectors dance and play,
App-wallets skip the unplugged way,
Browser friends pause, then try once more,
Stale paths cleared, the flow's restore—
A carrot for tests, hip-hop hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing the app-wallet add-account flow, which aligns with the core modifications in SeizeConnectContext.tsx and the new test suite validating this behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-app-wallet-add-account-flow

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prxt6529]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud