app placeholder fix

[ragnep]

Summary by CodeRabbit

• New Features

  • Added a loading skeleton UI for unauthenticated users.

• Improvements

  • Show wave avatar and name instead of the previous "Members Only" badge.
  • Refined header sizing, spacing, and description typography.
  • Adjusted logged-out rendering in app mode to streamline the preview behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3bd61871-a423-491e-919d-03d3580db674

📥 Commits

Reviewing files that changed from the base of the PR and between 65532f1 and 38a3cd4.

📒 Files selected for processing (1)

• components/waves/public/PublicWaveShell.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• components/waves/public/PublicWaveShell.tsx

---

📝 Walkthrough

Walkthrough

Refactors WavesLayout to render wallet connection immediately in app mode and prevent public shell loading there. Adds a LoggedOutSkeleton component and replaces the old locked preview in PublicWaveShell. PublicWaveShell data shape now includes a nullable picture field.

Changes

Cohort / File(s)	Summary
Authentication Flow components/waves/layout/WavesLayout.tsx	Immediately renders <ConnectWallet /> when isApp is true; updates usePublicWaveShellState enabled condition to require !isApp, avoiding public-shell loading in app mode.
Skeleton & Shell Components components/waves/public/LoggedOutSkeleton.tsx, components/waves/public/PublicWaveShell.tsx	Adds LoggedOutSkeleton (new file) and replaces the old locked-preview with it; removes "Members Only" badge, renders WavePicture avatar and adjusts layout/typography.
Public Wave Data Model components/waves/public/usePublicWaveShellState.ts	Extends PublicWaveShellData with `picture: string

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Wave header impro #2043: Integrates WavePicture and wave.picture handling—closely related to this PR's header rendering changes.
• logged out placeholder in the wave view #2153: Overlaps edits to PublicWaveShell and usePublicWaveShellState—likely touches the same code paths.
• wave logo edit #1758: Adds image input/editing for wave pictures, which complements the new picture field consumption.

Suggested reviewers

• simo6529
• prxt6529

Poem

🐰 A hop, a sketch, a skeleton bright,
Wave pictures gleam in morning light,
Wallet waits when app takes stage,
Public shell turns a fresher page,
Hooray — a rabbit cheers the sight! 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'app placeholder fix' is vague and generic, using non-descriptive terms that don't convey meaningful information about the changeset's primary objectives.	Consider a more descriptive title that captures the main change, such as 'Replace logged-out preview placeholder with skeleton UI' or 'Update public wave shell for app mode rendering'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch minor-fix-logged-out-placeholder

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

components/waves/public/usePublicWaveShellState.ts (1)

29-29: Optional cleanup: remove redundant nullish coalescing.

ApiWave.picture is already string | null, so ?? null is unnecessary noise.

♻️ Proposed simplification

-    picture: wave.picture ?? null,
+    picture: wave.picture,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/waves/public/usePublicWaveShellState.ts` at line 29, In
usePublicWaveShellState, remove the redundant nullish coalescing when assigning
picture: currently using "picture: wave.picture ?? null"; since ApiWave.picture
is already string | null, change this to "picture: wave.picture" to simplify the
code and avoid unnecessary noise.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@components/waves/public/usePublicWaveShellState.ts`:
- Line 29: In usePublicWaveShellState, remove the redundant nullish coalescing
when assigning picture: currently using "picture: wave.picture ?? null"; since
ApiWave.picture is already string | null, change this to "picture: wave.picture"
to simplify the code and avoid unnecessary noise.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df571aa7-f0ce-4d95-8a3d-9390122462df

📥 Commits

Reviewing files that changed from the base of the PR and between dfefe59 and 65532f1.

📒 Files selected for processing (4)

• components/waves/layout/WavesLayout.tsx
• components/waves/public/LoggedOutSkeleton.tsx
• components/waves/public/PublicWaveShell.tsx
• components/waves/public/usePublicWaveShellState.ts

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud