Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThreads a new size variant and required-marker support through trait components, refactors section-aware form layouts, updates many Tailwind classnames and layout structures across submission UI (modals, panels, file upload, preview), and adds/updates tests to assert the new visual states. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
components/waves/memes/MemesArtSubmissionTraits.tsx (1)
105-165: Consider extracting section titles as constants.The section-specific rendering logic relies on string comparisons (
"Basic Information","Card Points","Card Attributes"). If section titles are changed ingetFormSections, the layout logic here will silently fall back to the default grid without warning.🔧 Suggested improvement: use constants for section titles
// In schema.ts or a shared constants file export const SECTION_TITLES = { BASIC_INFO: "Basic Information", CARD_POINTS: "Card Points", CARD_ATTRIBUTES: "Card Attributes", } as const;Then use these constants in both
getFormSectionsand this component to ensure consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/MemesArtSubmissionTraits.tsx` around lines 105 - 165, This code compares literal section.title strings ("Basic Information", "Card Points", "Card Attributes") inside the render logic, which can break silently if getFormSections changes; refactor by extracting those literals into shared constants (e.g., SECTION_TITLES with keys BASIC_INFO, CARD_POINTS, CARD_ATTRIBUTES) and replace the string comparisons in this file (the if checks against section.title) and in getFormSections to use those constants; update any imports and ensure renderField and Section usage remains unchanged so layout behavior is preserved.components/waves/memes/traits/BooleanTrait.tsx (1)
117-125: Missingsizeprop for consistency with other trait components.
TextTrait,NumberTrait, andDropdownTraitall accept and forward asizeprop toTraitWrapper, butBooleanTraitdoes not. This inconsistency meansBooleanTraitwon't respond to size changes when used alongside other traits.The
TraitWrapperalready accepts asizeprop (as shown in the relevant code snippet), so this component should likely support it as well for a consistent API.🔧 Suggested fix: add size prop support
type BooleanTraitProps = { readonly label: string; readonly field: keyof TraitsData; readonly className?: string | undefined; readonly error?: string | null | undefined; readonly onBlur?: ((field: keyof TraitsData) => void) | undefined; readonly traits: TraitsData; readonly updateBoolean: (field: keyof TraitsData, value: boolean) => void; + readonly size?: "default" | "sm" | undefined; }; export const BooleanTrait: React.FC<BooleanTraitProps> = React.memo( - ({ label, field, traits, updateBoolean, className, error, onBlur }) => { + ({ label, field, traits, updateBoolean, className, error, onBlur, size = "default" }) => { // ... return ( <TraitWrapper label={label} isBoolean={true} className={className} error={error} id={`field-${field}`} isFieldFilled={isFieldFilled} + size={size} >🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/traits/BooleanTrait.tsx` around lines 117 - 125, BooleanTrait is not forwarding the size prop to TraitWrapper, causing inconsistent behavior with TextTrait/NumberTrait/DropdownTrait; update the BooleanTrait component to accept a size prop (same type/name used by the other traits) and pass it into the TraitWrapper JSX (add size={size} to the TraitWrapper props and include size in BooleanTrait's props destructuring/definition) so the component responds to size changes consistently with TextTrait, NumberTrait, and DropdownTrait.components/waves/memes/traits/Section.tsx (1)
32-41: Custom equality function excludeschildrenfrom comparison.The comment states "React handles children comparison internally," but this is incorrect when using a custom comparator with
React.memo. React does not automatically compare children when you provide a custom equality function—it only uses your function.If only the
childrenprop changes (whiletitleandclassNameremain the same), this component will skip re-rendering, potentially displaying stale content.In practice, this may not cause issues if the parent always re-renders when children need to update, but the comment is misleading.
🔧 Suggested fix: either remove the custom comparator or include children
Option 1 - Remove custom comparator (simpler, React's default shallow comparison handles this):
-export const Section = memo(SectionComponent, areSectionPropsEqual); +export const Section = memo(SectionComponent);Option 2 - Update the comment to clarify the intentional behavior:
- // React handles children comparison internally + // Children comparison intentionally skipped - parent re-renders will propagate changes🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/traits/Section.tsx` around lines 32 - 41, The custom comparator areSectionPropsEqual in Section.tsx incorrectly omits children comparison so React.memo will skip rerenders when only children change; fix by either removing the custom comparator so React.memo uses its default shallow prop comparison, or update areSectionPropsEqual to also compare prevProps.children !== nextProps.children (or a deep/shallow comparison appropriate for your children) and update the inline comment to reflect that children are being checked; reference the SectionProps shape, the areSectionPropsEqual function, and the title/className comparisons when making the change.components/waves/memes/submission/details/ArtworkDetails.tsx (1)
115-119: Consider extracting repeated size class fragments.The same
size === "sm"class logic is duplicated for both label and control blocks; a small helper/constant would reduce drift.Also applies to: 137-141, 160-164, 184-188
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/submission/details/ArtworkDetails.tsx` around lines 115 - 119, The repeated size-dependent class expression (size === "sm" ? "tw-text-[11px]" : "tw-text-xs") in ArtworkDetails is duplicated across multiple className usages (label and control blocks around the size checks at the shown diff and also at the blocks referenced 137-141, 160-164, 184-188); extract that expression into a small local constant or helper (e.g., sizeTextClass or getSizeTextClass(size)) at the top of the ArtworkDetails component and replace each inline ternary with that constant to remove duplication and keep behavior identical.components/waves/memes/traits/TraitWrapper.tsx (1)
65-65: Add explicitrequiredproperty to field definitions instead of coupling to!readOnly.The required indicator (
*) at line 65 is shown for all editable fields because it's tied to!readOnly. However,FieldDefinitionhas norequiredproperty to distinguish between required and optional editable fields. If optional trait fields need to be added, the UI and validation logic cannot represent them without refactoring. Add arequiredproperty toBaseFieldDefinitionand update the indicator logic and validation rules accordingly.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/traits/TraitWrapper.tsx` at line 65, Add an explicit required flag to the field model: extend BaseFieldDefinition (and any FieldDefinition union types) with a required?: boolean (default false) so traits can declare required vs optional; in TraitWrapper.tsx replace the current indicator condition {!readOnly && <span...>} with a check against field.required (e.g., show the red * only when field.required is true) and update any validation logic/functions that currently infer requiredness from !readOnly to instead read field.required (ensure creation/edit paths set required appropriately when constructing field definitions).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/waves/memes/traits/NumberTrait.tsx`:
- Around line 169-173: The isFieldFilled useMemo currently treats n === 0 as not
filled which incorrectly rejects valid zero values; in the isFieldFilled logic
(inside the useMemo that parses currentInputValue with Number.parseFloat) remove
the explicit n === 0 check so zero is considered filled, and keep the other
guards (Number.isFinite(n), min/max comparisons) unchanged so empty/NaN and
out-of-range values still return false.
---
Nitpick comments:
In `@components/waves/memes/MemesArtSubmissionTraits.tsx`:
- Around line 105-165: This code compares literal section.title strings ("Basic
Information", "Card Points", "Card Attributes") inside the render logic, which
can break silently if getFormSections changes; refactor by extracting those
literals into shared constants (e.g., SECTION_TITLES with keys BASIC_INFO,
CARD_POINTS, CARD_ATTRIBUTES) and replace the string comparisons in this file
(the if checks against section.title) and in getFormSections to use those
constants; update any imports and ensure renderField and Section usage remains
unchanged so layout behavior is preserved.
In `@components/waves/memes/submission/details/ArtworkDetails.tsx`:
- Around line 115-119: The repeated size-dependent class expression (size ===
"sm" ? "tw-text-[11px]" : "tw-text-xs") in ArtworkDetails is duplicated across
multiple className usages (label and control blocks around the size checks at
the shown diff and also at the blocks referenced 137-141, 160-164, 184-188);
extract that expression into a small local constant or helper (e.g.,
sizeTextClass or getSizeTextClass(size)) at the top of the ArtworkDetails
component and replace each inline ternary with that constant to remove
duplication and keep behavior identical.
In `@components/waves/memes/traits/BooleanTrait.tsx`:
- Around line 117-125: BooleanTrait is not forwarding the size prop to
TraitWrapper, causing inconsistent behavior with
TextTrait/NumberTrait/DropdownTrait; update the BooleanTrait component to accept
a size prop (same type/name used by the other traits) and pass it into the
TraitWrapper JSX (add size={size} to the TraitWrapper props and include size in
BooleanTrait's props destructuring/definition) so the component responds to size
changes consistently with TextTrait, NumberTrait, and DropdownTrait.
In `@components/waves/memes/traits/Section.tsx`:
- Around line 32-41: The custom comparator areSectionPropsEqual in Section.tsx
incorrectly omits children comparison so React.memo will skip rerenders when
only children change; fix by either removing the custom comparator so React.memo
uses its default shallow prop comparison, or update areSectionPropsEqual to also
compare prevProps.children !== nextProps.children (or a deep/shallow comparison
appropriate for your children) and update the inline comment to reflect that
children are being checked; reference the SectionProps shape, the
areSectionPropsEqual function, and the title/className comparisons when making
the change.
In `@components/waves/memes/traits/TraitWrapper.tsx`:
- Line 65: Add an explicit required flag to the field model: extend
BaseFieldDefinition (and any FieldDefinition union types) with a required?:
boolean (default false) so traits can declare required vs optional; in
TraitWrapper.tsx replace the current indicator condition {!readOnly &&
<span...>} with a check against field.required (e.g., show the red * only when
field.required is true) and update any validation logic/functions that currently
infer requiredness from !readOnly to instead read field.required (ensure
creation/edit paths set required appropriately when constructing field
definitions).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0b773e2b-6192-4e96-bd08-8b3c98c607c7
📒 Files selected for processing (12)
components/waves/memes/MemesArtSubmissionModal.tsxcomponents/waves/memes/MemesArtSubmissionTraits.tsxcomponents/waves/memes/submission/MemesArtSubmissionContainer.tsxcomponents/waves/memes/submission/details/ArtworkDetails.tsxcomponents/waves/memes/submission/steps/ArtworkStep.tsxcomponents/waves/memes/traits/BooleanTrait.tsxcomponents/waves/memes/traits/DropdownTrait.tsxcomponents/waves/memes/traits/NumberTrait.tsxcomponents/waves/memes/traits/Section.tsxcomponents/waves/memes/traits/TextTrait.tsxcomponents/waves/memes/traits/TraitField.tsxcomponents/waves/memes/traits/TraitWrapper.tsx
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (6)
components/waves/memes/submission/MemesArtSubmissionContainer.tsx (1)
305-305: Remove no-op responsive border utility on the header row.On Line 305,
lg:tw-border-b-0has no effect because this element never setstw-border-b(the border-bottom is on the parent div at Line 303). Removing it reduces class noise.Proposed diff
- className="tw-flex tw-w-full tw-items-center tw-flex-shrink-0 tw-justify-between tw-pt-6 lg:tw-border-b-0" + className="tw-flex tw-w-full tw-items-center tw-flex-shrink-0 tw-justify-between tw-pt-6"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/submission/MemesArtSubmissionContainer.tsx` at line 305, In the MemesArtSubmissionContainer component remove the redundant responsive utility from the header row: delete the `lg:tw-border-b-0` token from the className string on the header element (the element with className starting "tw-flex tw-w-full tw-items-center tw-flex-shrink-0 tw-justify-between tw-pt-6"); this simply eliminates a no-op Tailwind class since the border-bottom is applied on the parent and not this element.constants/submission-media.constants.ts (1)
83-87: Consider whether the "GLB" label for interactive fully represents supported formats.The
interactivecategory inSUBMISSION_MEDIA_TYPESincludes GLB, GLTF, and HTML formats, but the UI label only shows "GLB". If this is intentional to keep the UI simple, this is fine. Otherwise, consider updating the label to reflect all supported interactive formats.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@constants/submission-media.constants.ts` around lines 83 - 87, The UI label for the interactive group is currently "GLB" but the interactive category (see SUBMISSION_MEDIA_TYPES and the SUBMISSION_UI_FORMAT_GROUPS constant) actually supports GLB, GLTF, and HTML; update the label in SUBMISSION_UI_FORMAT_GROUPS (the entry with kind: "interactive") to either list all supported formats (e.g., "GLB, GLTF, HTML") or a more generic term like "INTERACTIVE" to accurately reflect supported types, ensuring the displayed text matches the formats defined in SUBMISSION_MEDIA_TYPES.components/waves/memes/traits/TraitField.tsx (1)
92-103:BooleanTraitdoesn't receiveshowRequiredMarkerorsizeprops.Unlike
TextTrait,NumberTrait, andDropdownTrait,BooleanTraitdoesn't receive the new props. If this is intentional (e.g., boolean fields have fixed sizing), a brief comment would clarify this design decision. Otherwise, consider whetherBooleanTraitshould also support these props for consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/traits/TraitField.tsx` around lines 92 - 103, The BooleanTrait rendering in TraitField.tsx omits the new props showRequiredMarker and size that TextTrait, NumberTrait and DropdownTrait receive; either pass showRequiredMarker={showRequiredMarker} and size={size} into the <BooleanTrait ... /> JSX so BooleanTrait gets consistent behavior, or if omission is intentional, add a brief comment above the BooleanTrait return explaining that booleans have fixed sizing and do not support showRequiredMarker/size; update the BooleanTrait prop type (component) if you choose to support the props.components/waves/memes/submission/ui/FormSection.tsx (1)
28-28: Behavior change for falsyheaderRightvalues.The change from
headerRight && ...toheaderRight !== undefinednow renders the wrapper<div>for falsy values likenull,0,"", orfalse. IfheaderRight={null}is explicitly passed, an empty<div>will render, which may affect layout spacing.If preserving space for falsy content is intentional, consider adding a brief comment. Otherwise, the previous truthiness check was safer.
Alternative: Check for both undefined and null
- {headerRight !== undefined && <div>{headerRight}</div>} + {headerRight != null && <div>{headerRight}</div>}This excludes both
undefinedandnullwhile still allowing0orfalseif needed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/submission/ui/FormSection.tsx` at line 28, The conditional in FormSection.tsx now uses headerRight !== undefined which causes a wrapper <div> to render for other falsy values (null, 0, "", false); revert to a truthiness check or explicitly exclude null as well to avoid rendering an empty wrapper when headerRight is null—update the condition around the headerRight render in the FormSection component to either use headerRight && <div>{headerRight}</div> or use an explicit null/undefined guard (e.g., headerRight != null) depending on whether you want to allow 0/false as valid content, and add a short comment clarifying the chosen behavior.__tests__/components/waves/memes/traits/DropdownTrait.test.tsx (1)
78-87: Hardcoded RGB values make tests brittle.Asserting exact RGB values (
rgb(132, 132, 144),rgb(239, 239, 241)) tightly couples tests to specific color implementations. Consider asserting on the presence/absence of style properties or CSS variables instead, which would be more maintainable if design tokens change.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@__tests__/components/waves/memes/traits/DropdownTrait.test.tsx` around lines 78 - 87, The test is brittle because it asserts exact RGB strings for the select element color; update the assertions around select and iconContainer (used with fireEvent.change and expect(...).toHaveClass) to check semantics instead of hardcoded colors — e.g., assert that (select as HTMLSelectElement).style.color is truthy/empty or that the element uses the expected CSS variable/class (check computedStyle.getPropertyValue('--your-color-var') or presence/absence of a modifier class) before and after fireEvent.change(select, { target: { value: "Rare" } }) so the test validates behavior without relying on exact RGB values.components/waves/memes/MemesArtSubmissionTraits.tsx (1)
79-81: Use stable section ids for layout branching.The
"Basic Information","Card Points", and"Card Attributes"checks make rendering depend on display copy fromgetFormSections. A title rename/localization would silently change both the chosen layout and thesectionKey. A schema-levelid/layoutfield would keep this stable.Also applies to: 108-156
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/waves/memes/MemesArtSubmissionTraits.tsx` around lines 79 - 81, The section key and layout branching currently rely on display copy (section.title and field names) in the sectionKey calculation and downstream checks, which is brittle; update the code to prefer a stable schema identifier (e.g., section.id or section.layout) when available and fall back to the old logic only if that id is missing. Specifically, change uses in MemesArtSubmissionTraits (the sectionKey computation and any conditional checks for "Basic Information", "Card Points", "Card Attributes") to first read section.id or section.layout (e.g., section.id || section.layout || previousTitleFallback) and update the layout-branching conditions to match those stable ids instead of the display titles; apply the same change to the other occurrences referenced (lines ~108-156) so rendering and keys are resilient to title changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@__tests__/components/waves/memes/submission/details/ArtworkDetails.test.tsx`:
- Around line 63-68: The test assertions in ArtworkDetails.test.tsx expect the
filled input class 'tw-ring-emerald-500/30' but the components apply
'tw-ring-emerald-600/45'; update the expectations in the test (the two
expect(...) checks that use screen.getByLabelText(/Artwork Title/) and
screen.getByLabelText(/Description/)) to assert for 'tw-ring-emerald-600/45' so
they match the implementation in ArtworkDetails (line ~27) and TextTrait (line
~117).
In `@__tests__/components/waves/memes/traits/TextTrait.test.tsx`:
- Line 45: The test in TextTrait.test.tsx is asserting the wrong ring class;
update the expectation to match the component's filled-state class used in
TextTrait.tsx (the TextTrait component applies "tw-ring-emerald-600/45" for the
filled state), so change the assertion from
expect(input).toHaveClass("tw-ring-emerald-500/30") to
expect(input).toHaveClass("tw-ring-emerald-600/45") (or adjust the component if
you intend the other value), referencing the TextTrait component's filled-state
logic to keep the test and implementation in sync.
In `@components/waves/memes/MemesArtSubmissionFile.tsx`:
- Around line 174-195: providerOptions is typed as
CommonSelectItem<InteractiveMediaProvider> but sets value: provider.key
(string), so handleProviderSelect (which expects InteractiveMediaProvider)
receives a string; either make the select value the provider object or change
types/callbacks to use string keys. Fix by updating providerOptions mapping to
use value: provider (not provider.key) and ensure INTERACTIVE_MEDIA_PROVIDERS
items are the InteractiveMediaProvider shape so CommonTabsTab will call
setSelected with the object, or alternatively change the generic on
providerOptions to CommonSelectItem<string>[] and adjust handleProviderSelect
signature to (providerKey: string) and call onExternalProviderChange with the
providerKey (or look up the object from INTERACTIVE_MEDIA_PROVIDERS before
comparing with externalProvider). Ensure references: providerOptions,
handleProviderSelect, INTERACTIVE_MEDIA_PROVIDERS, externalProvider,
onExternalProviderChange, CommonSelectItem, CommonTabsTab are updated
consistently.
In `@components/waves/memes/submission/components/AdditionalMediaUpload.tsx`:
- Around line 311-327: The textareas inside the TraitWrapper (e.g., the one
bound to aboutArtist with value={aboutArtist} and onChange calling
onAboutArtistChange) are visually marked required but lack semantic required
attributes; add aria-required="true" (or required if you want native browser
validation) to these textarea elements and do the same for the other textarea(s)
noted (the block around lines 333-349) so screen readers announce the required
constraint and accessibility matches the step validation; keep existing
aria/error handling (errors?.aboutArtist) intact.
In `@components/waves/memes/submission/components/AirdropConfig.tsx`:
- Around line 178-185: The required-star is shown unconditionally on each
TraitWrapper in AirdropConfig (prop showRequiredMarker=true) which contradicts
the validation rules: an address is required only when count > 0 (and count is
required only when an address exists) in AdditionalInfo logic; update the
rendering in AirdropConfig to compute a boolean like isActiveRow (e.g., based on
the corresponding row's count > 0 or existing address for the given index) and
pass that to TraitWrapper's showRequiredMarker so the star appears only for
active/validated rows (also update the other occurrence around lines 201-207 the
same way).
---
Nitpick comments:
In `@__tests__/components/waves/memes/traits/DropdownTrait.test.tsx`:
- Around line 78-87: The test is brittle because it asserts exact RGB strings
for the select element color; update the assertions around select and
iconContainer (used with fireEvent.change and expect(...).toHaveClass) to check
semantics instead of hardcoded colors — e.g., assert that (select as
HTMLSelectElement).style.color is truthy/empty or that the element uses the
expected CSS variable/class (check
computedStyle.getPropertyValue('--your-color-var') or presence/absence of a
modifier class) before and after fireEvent.change(select, { target: { value:
"Rare" } }) so the test validates behavior without relying on exact RGB values.
In `@components/waves/memes/MemesArtSubmissionTraits.tsx`:
- Around line 79-81: The section key and layout branching currently rely on
display copy (section.title and field names) in the sectionKey calculation and
downstream checks, which is brittle; update the code to prefer a stable schema
identifier (e.g., section.id or section.layout) when available and fall back to
the old logic only if that id is missing. Specifically, change uses in
MemesArtSubmissionTraits (the sectionKey computation and any conditional checks
for "Basic Information", "Card Points", "Card Attributes") to first read
section.id or section.layout (e.g., section.id || section.layout ||
previousTitleFallback) and update the layout-branching conditions to match those
stable ids instead of the display titles; apply the same change to the other
occurrences referenced (lines ~108-156) so rendering and keys are resilient to
title changes.
In `@components/waves/memes/submission/MemesArtSubmissionContainer.tsx`:
- Line 305: In the MemesArtSubmissionContainer component remove the redundant
responsive utility from the header row: delete the `lg:tw-border-b-0` token from
the className string on the header element (the element with className starting
"tw-flex tw-w-full tw-items-center tw-flex-shrink-0 tw-justify-between
tw-pt-6"); this simply eliminates a no-op Tailwind class since the border-bottom
is applied on the parent and not this element.
In `@components/waves/memes/submission/ui/FormSection.tsx`:
- Line 28: The conditional in FormSection.tsx now uses headerRight !== undefined
which causes a wrapper <div> to render for other falsy values (null, 0, "",
false); revert to a truthiness check or explicitly exclude null as well to avoid
rendering an empty wrapper when headerRight is null—update the condition around
the headerRight render in the FormSection component to either use headerRight &&
<div>{headerRight}</div> or use an explicit null/undefined guard (e.g.,
headerRight != null) depending on whether you want to allow 0/false as valid
content, and add a short comment clarifying the chosen behavior.
In `@components/waves/memes/traits/TraitField.tsx`:
- Around line 92-103: The BooleanTrait rendering in TraitField.tsx omits the new
props showRequiredMarker and size that TextTrait, NumberTrait and DropdownTrait
receive; either pass showRequiredMarker={showRequiredMarker} and size={size}
into the <BooleanTrait ... /> JSX so BooleanTrait gets consistent behavior, or
if omission is intentional, add a brief comment above the BooleanTrait return
explaining that booleans have fixed sizing and do not support
showRequiredMarker/size; update the BooleanTrait prop type (component) if you
choose to support the props.
In `@constants/submission-media.constants.ts`:
- Around line 83-87: The UI label for the interactive group is currently "GLB"
but the interactive category (see SUBMISSION_MEDIA_TYPES and the
SUBMISSION_UI_FORMAT_GROUPS constant) actually supports GLB, GLTF, and HTML;
update the label in SUBMISSION_UI_FORMAT_GROUPS (the entry with kind:
"interactive") to either list all supported formats (e.g., "GLB, GLTF, HTML") or
a more generic term like "INTERACTIVE" to accurately reflect supported types,
ensuring the displayed text matches the formats defined in
SUBMISSION_MEDIA_TYPES.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1ba803fe-88f4-4b15-9a73-f59d2b38ce44
📒 Files selected for processing (27)
__tests__/components/waves/memes/submission/details/ArtworkDetails.test.tsx__tests__/components/waves/memes/traits/DropdownTrait.test.tsx__tests__/components/waves/memes/traits/TextTrait.test.tsx__tests__/components/waves/memes/traits/TraitWrapper.test.tsxcomponents/waves/memes/MemesArtSubmissionFile.tsxcomponents/waves/memes/MemesArtSubmissionTraits.tsxcomponents/waves/memes/file-upload/components/FilePreview.tsxcomponents/waves/memes/file-upload/components/FileTypeIndicator.tsxcomponents/waves/memes/file-upload/components/UploadArea.tsxcomponents/waves/memes/submission/MemesArtSubmissionContainer.tsxcomponents/waves/memes/submission/components/AdditionalMediaUpload.tsxcomponents/waves/memes/submission/components/AirdropConfig.tsxcomponents/waves/memes/submission/components/AllowlistBatchManager.tsxcomponents/waves/memes/submission/components/PaymentConfig.tsxcomponents/waves/memes/submission/details/ArtworkDetails.tsxcomponents/waves/memes/submission/preview/MemesSubmissionPreviewScreen.tsxcomponents/waves/memes/submission/steps/AdditionalInfoStep.tsxcomponents/waves/memes/submission/steps/AgreementStep.tsxcomponents/waves/memes/submission/steps/ArtworkStep.tsxcomponents/waves/memes/submission/ui/FormSection.tsxcomponents/waves/memes/traits/DropdownTrait.tsxcomponents/waves/memes/traits/NumberTrait.tsxcomponents/waves/memes/traits/Section.tsxcomponents/waves/memes/traits/TextTrait.tsxcomponents/waves/memes/traits/TraitField.tsxcomponents/waves/memes/traits/TraitWrapper.tsxconstants/submission-media.constants.ts
✅ Files skipped from review due to trivial changes (3)
- components/waves/memes/submission/preview/MemesSubmissionPreviewScreen.tsx
- components/waves/memes/file-upload/components/FilePreview.tsx
- components/waves/memes/submission/components/AllowlistBatchManager.tsx
🚧 Files skipped from review as they are similar to previous changes (5)
- components/waves/memes/submission/details/ArtworkDetails.tsx
- components/waves/memes/traits/DropdownTrait.tsx
- components/waves/memes/submission/steps/ArtworkStep.tsx
- components/waves/memes/traits/TraitWrapper.tsx
- components/waves/memes/traits/NumberTrait.tsx
|
simo6529
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Tests