Skip to content

Mint Phases time fix + marketplaces#2112

Merged
prxt6529 merged 1 commit intomainfrom
mint-phase-marketplaces
Mar 13, 2026
Merged

Mint Phases time fix + marketplaces#2112
prxt6529 merged 1 commit intomainfrom
mint-phase-marketplaces

Conversation

@prxt6529
Copy link
Copy Markdown
Collaborator

@prxt6529 prxt6529 commented Mar 13, 2026

Summary by CodeRabbit

  • Refactor
    • Marketplace links now display dynamically based on contract type, improving relevance for users.
    • Phase generation timing reference updated to prioritize claim start date for more accurate calculations.

Signed-off-by: prxt6529 <prxt@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4ce9e46a-ef26-4709-8bfe-3d1c00a9a5cf

📥 Commits

Reviewing files that changed from the base of the PR and between 92e2a61 and 24d71eb.

📒 Files selected for processing (2)
  • components/manifold-minting/ManifoldMinting.tsx
  • components/nft-marketplace-links/NFTMarketplaceLinks.tsx

📝 Walkthrough

Walkthrough

Two components were refactored: ManifoldMinting.tsx now anchors phase calculations to claim.startDate instead of mint_date when available, and NFTMarketplaceLinks.tsx replaces hard-coded marketplace link JSX with a data-driven MARKETPLACES constant structure supporting dynamic visibility filtering.

Changes

Cohort / File(s) Summary
Phase Anchoring Logic
components/manifold-minting/ManifoldMinting.tsx
Modified phase calculation to use claim.startDate as anchor date when available (startDate > 0), otherwise falls back to mint_date, changing the timing reference for phase generation.
Marketplace Links Refactoring
components/nft-marketplace-links/NFTMarketplaceLinks.tsx
Introduced typed MarketplaceLink structure and MARKETPLACES constant to drive marketplace data; replaced hard-coded individual marketplace link JSX blocks with data-driven map rendering; added shouldShow conditional visibility logic for Blur marketplace.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • #1579: Refactors phase construction/usage to compute phases per-call using startDate, directly complementing the anchor date change in ManifoldMinting.tsx.

Suggested reviewers

  • simo6529
  • ragnep

Poem

🐰 A rabbit hops through linked marketplaces so grand,
With data-driven structure, each link now planned,
And phases that dance to a claim's starting beat,
No more hard-coded chaos—just clean, neat!
✨🔗

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly corresponds to the two main changes: fixing mint phase timing logic and refactoring marketplace links to be data-driven.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mint-phase-marketplaces
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@prxt6529 prxt6529 merged commit b52aa4b into main Mar 13, 2026
7 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants