show quoted drop correctly for non-meme wave

[simo6529]

Summary by CodeRabbit

• New Features

  • Improved drop link parsing with specialized handling for meme waves versus regular waves
  • Added protection against circular drop references with error detection

• Bug Fixes

  • Enhanced link validation for edge cases and missing wave contexts

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 640d15a and da6c75b.

📒 Files selected for processing (8)

• __tests__/components/drops/view/part/dropPartMarkdown/handlers/seize.test.tsx
• __tests__/helpers/SeizeLinkParser.test.ts
• components/drops/view/part/DropPartMarkdown.tsx
• components/drops/view/part/dropPartMarkdown/handlers/seize.tsx
• components/drops/view/part/dropPartMarkdown/linkHandlers.tsx
• components/drops/view/part/dropPartMarkdown/renderers.tsx
• contexts/SeizeSettingsContext.tsx
• helpers/SeizeLinkParser.ts

---

📝 Walkthrough

Walkthrough

Introduces parseSeizeDropLink parser and isMemesWaveById configuration to identify memes waves. Updates the link rendering pipeline to conditionally render seize quotes based on wave type, adds recursion guard for drop-to-drop references, and creates optional SeizeSettings hook for flexible context consumption.

Changes

Cohort / File(s)	Summary
Test Coverage __tests__/components/drops/view/part/dropPartMarkdown/handlers/seize.test.tsx, __tests__/helpers/SeizeLinkParser.test.ts	Comprehensive test suites for new seize drop handler and parseSeizeDropLink parser, covering memes waves, non-memes quote rendering, wave unavailability fallback, and recursion guard validation.
Core Link Parsing helpers/SeizeLinkParser.ts, contexts/SeizeSettingsContext.tsx	Adds parseSeizeDropLink export for parsing drop links with wave/drop extraction, marks getSeizeBaseOrigin as internal, and introduces useSeizeSettingsOptional hook for optional context consumption.
Link Handler Pipeline components/drops/view/part/DropPartMarkdown.tsx, components/drops/view/part/dropPartMarkdown/linkHandlers.tsx, components/drops/view/part/dropPartMarkdown/handlers/seize.tsx	Threads isMemesWaveById configuration through rendering pipeline from DropPartMarkdown via linkHandlers to seize handler; seize handler uses parseSeizeDropLink and conditionally invokes renderSeizeQuote when wave is not a memes wave.
Renderer Cleanup components/drops/view/part/dropPartMarkdown/renderers.tsx	Removes getWaveRoute import and relativeHref routing logic from drop quote renderer LinkHandlerFrame.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• 6529-Collections/6529seize-frontend#1621: Modifies parseSeizeQuoteLink to short-circuit when drop parameter is present, complementing the new drop-specific parsing logic introduced here.
• 6529-Collections/6529seize-frontend#1605: Modifies createSeizeHandlers and implements currentDropId recursion guard logic that parallels the seize drop handler changes in this PR.
• 6529-Collections/6529seize-frontend#1949: Updates LinkRendererConfig plumbing to thread additional optional handler configuration (similar pattern to isMemesWaveById threading in this PR).

Suggested reviewers

• ragnep
• prxt6529

Poem

🐰 A parser springs forth to tame the drop,
With memes-wave detection that won't stop,
Through handlers and hooks, configuration flows,
While recursion guards stand at the rows,
Seize quotes render when the wave permits! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding logic to correctly display quoted drops for non-meme waves by introducing the isMemesWaveById flag throughout the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch marketplace-image-wont-show-up

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da6c75ba82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud