Skip to content

More visible pinned drop#2037

Merged
simo6529 merged 3 commits intomainfrom
more-visible-pinned-drop
Mar 3, 2026
Merged

More visible pinned drop#2037
simo6529 merged 3 commits intomainfrom
more-visible-pinned-drop

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Mar 3, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • Added wave description previews accessible via a "Show wave description" button in wave headers across the app
    • Wave description text now displays inline in stream tabs and app headers on both mobile and desktop layouts
    • Description preview text automatically converts markdown formatting to plain text for improved readability

simo6529 added 2 commits March 3, 2026 07:52
Signed-off-by: Simo <simo@6529.io>
Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2767343 and 9aec853.

📒 Files selected for processing (10)
  • __tests__/components/brain/my-stream/tabs/MyStreamWaveTabsDefault.test.tsx
  • __tests__/components/brain/my-stream/tabs/MyStreamWaveTabsMeme.test.tsx
  • __tests__/components/header/AppHeader.test.tsx
  • __tests__/components/waves/header/WaveDescriptionPopover.test.tsx
  • __tests__/helpers/waves/waveDescriptionPreview.test.ts
  • components/brain/my-stream/tabs/MyStreamWaveTabsDefault.tsx
  • components/brain/my-stream/tabs/MyStreamWaveTabsMeme.tsx
  • components/header/AppHeader.tsx
  • components/waves/header/WaveDescriptionPopover.tsx
  • helpers/waves/waveDescriptionPreview.ts

📝 Walkthrough

Walkthrough

Introduces wave description preview functionality by adding a new WaveDescriptionPopover component and a Markdown-to-plaintext helper, then integrating them into existing stream tab components and the app header to display wave descriptions via floating popovers.

Changes

Cohort / File(s) Summary
Wave Description Infrastructure
components/waves/header/WaveDescriptionPopover.tsx, helpers/waves/waveDescriptionPreview.ts
New WaveDescriptionPopover component with responsive portal-based popover rendering and positioning logic; new helper to convert Markdown wave descriptions to plain-text previews for UI display.
Stream Tab Components
components/brain/my-stream/tabs/MyStreamWaveTabsDefault.tsx, components/brain/my-stream/tabs/MyStreamWaveTabsMeme.tsx
Integrated WaveDescriptionPopover and preview-text computation to conditionally render description triggers and content in mobile and desktop layouts.
Header Component
components/header/AppHeader.tsx
Added preview-text derivation and conditional WaveDescriptionPopover rendering in the header title area for non-DM active waves.
Tests – Infrastructure
__tests__/components/waves/header/WaveDescriptionPopover.test.tsx, __tests__/helpers/waves/waveDescriptionPreview.test.ts
New test suites covering WaveDescriptionPopover open/close/portal behavior and WaveDescriptionPreviewText Markdown-to-plaintext conversion edge cases.
Tests – Stream Tabs & Header
__tests__/components/brain/my-stream/tabs/MyStreamWaveTabsDefault.test.tsx, __tests__/components/brain/my-stream/tabs/MyStreamWaveTabsMeme.test.tsx, __tests__/components/header/AppHeader.test.tsx
Extended test fixtures and added assertions verifying description subtitle/trigger presence for non-DM waves and absence for DM waves; added mocks for new popover components.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • ragnep
  • prxt6529
  • GelatoGenesis

Poem

🐰 Hop, click, and behold—descriptions now shine,
Wave popovers dance in responsive design,
Markdown to plain text, we parse with such care,
Description drops floating through desktop and air!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The PR title 'More visible pinned drop' is vague and doesn't clearly describe the actual changes, which focus on adding wave description preview functionality across multiple components. Consider a more specific title like 'Add wave description preview popover' or 'Display wave description previews in headers' that accurately reflects the main feature being introduced.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch more-visible-pinned-drop

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9aec85300d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread helpers/waves/waveDescriptionPreview.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@simo6529 simo6529 merged commit ccb39bd into main Mar 3, 2026
6 of 7 checks passed
@simo6529 simo6529 deleted the more-visible-pinned-drop branch March 3, 2026 12:46
@coderabbitai coderabbitai Bot mentioned this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants