Remove last drop showing at homepage

[simo6529]

Summary by CodeRabbit

• Refactor
  • Optimized internal mint visibility logic by removing unnecessary time-based parameters and dependencies that were no longer needed.
  • Streamlined conditional checks and helper function implementations that determine visibility of upcoming mints and winner information.
  • Enhanced code maintainability and clarity through simplified implementations and reduced complexity.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

This PR simplifies the mint visibility helper functions by removing the now parameter and dependency on isMintingDayUtc, reducing both function implementations to direct boolean computations based solely on isMintEnded and nextMintExists.

Changes

Cohort / File(s)	Summary
Mint Visibility Helpers Simplification helpers/mint-visibility.helpers.ts	Removed now parameter from ShouldShowNextMintAfterEndParams interface and updated function signatures for shouldShowNextMintInLatestDrop and shouldShowNextWinnerInComingUp. Simplified logic to pure boolean computations without isMintingDayUtc dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• #1879 — Modifies the same helpers in mint-visibility.helpers.ts with changes to function signatures and logic.

Suggested reviewers

• ragnep

Poem

🐰 A rabbit hops through helper code so neat,
Removing clutter, making logic sweet,
No now parameter clouds the way,
Pure boolean returns save the day! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Remove last drop showing at homepage' is vague and does not clearly convey the actual technical changes made to the codebase. The changes involve removing the 'now' parameter, simplifying logic in visibility helper functions, and modifying the ShouldShowNextMintAfterEndParams interface—none of which are specifically reflected in the title.	Consider using a more specific title that reflects the actual implementation changes, such as 'Simplify visibility helpers by removing now parameter' or 'Refactor ShouldShowNextMintAfterEndParams and visibility logic'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-last-drop-showing-at-homepage

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud