Skip to content

emoji scroll and zoom fix#1931

Merged
ragnep merged 2 commits intomainfrom
app-wave-ux-fixes-v2
Feb 16, 2026
Merged

emoji scroll and zoom fix#1931
ragnep merged 2 commits intomainfrom
app-wave-ux-fixes-v2

Conversation

@ragnep
Copy link
Copy Markdown
Contributor

@ragnep ragnep commented Feb 16, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed touch event handling in the mobile emoji picker to prevent unintended interactions with underlying content.
  • Style

    • Adjusted emoji picker font sizing for better readability on mobile devices.

Signed-off-by: ragnep <ragneinfo@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Three files modified to enhance mobile emoji picker behavior: touch move event propagation is prevented in two picker wrapper components, and emoji picker font size styling is added to the global stylesheet.

Changes

Cohort / File(s) Summary
Mobile Emoji Picker Touch Handling
components/waves/CreateDropEmojiPicker.tsx, components/waves/drops/WaveDropActionsAddReaction.tsx
Added onTouchMove={(e) => e.stopPropagation()} handler to mobile emoji picker wrapper divs to prevent touch move events from bubbling to parent elements.
Emoji Picker Styling
styles/globals.scss
Added CSS rule for em-emoji-picker element setting custom property --font-size to 17px.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Touchscreen v2 #1851: Refactors touch-move gating and long-press logic in mobile emoji picker interactions, complementing the touch event propagation fixes.
  • Reactions dialog #1718: Modifies WaveDropActionsAddReaction to handle touch event propagation in the mobile emoji picker, directly overlapping with this PR's changes.

Suggested reviewers

  • simo6529
  • GelatoGenesis

Poem

🐰✨ A gentle paw upon the screen,
Touch events now stay pristine,
No bubbles float where they shouldn't be,
Emoji picker flows wild and free!
With font sizes set just right,
Mobile interactions take flight! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'emoji scroll and zoom fix' is vague and does not clearly describe the specific changes made. The actual changes involve adding touch event propagation handling and CSS font-size property, which are not directly related to 'scroll and zoom'. Provide a more specific title that accurately describes the changes, such as 'Stop touch propagation in emoji picker mobile wrapper' or 'Add touch event handling to mobile emoji picker'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch app-wave-ux-fixes-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: ragnep <ragneinfo@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

@ragnep ragnep merged commit d052df1 into main Feb 16, 2026
7 checks passed
@ragnep ragnep deleted the app-wave-ux-fixes-v2 branch February 16, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants