Skip to content

fix notifications page flickering and extra bottom height#1889

Merged
ragnep merged 1 commit intomainfrom
notifications-page-ux-fix
Feb 4, 2026
Merged

fix notifications page flickering and extra bottom height#1889
ragnep merged 1 commit intomainfrom
notifications-page-ux-fix

Conversation

@ragnep
Copy link
Copy Markdown
Contributor

@ragnep ragnep commented Feb 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed potential display overflow in the notifications section
    • Improved layout handling for notification preview components

Signed-off-by: ragnep <ragneinfo@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Two notification components receive layout adjustments: invisible measuring wrappers in CollapsibleDropPreview shift from fixed to absolute positioning to preserve offset anchoring, and NotificationsPage's outer container gains overflow-hidden to contain content within boundaries.

Changes

Cohort / File(s) Summary
Notification Layout Adjustments
components/brain/notifications/subcomponents/CollapsibleDropPreview.tsx, components/notifications/NotificationsPage.tsx
Modified CSS positioning strategy in measuring wrappers (fixed → absolute) and added overflow-hidden class to notification page container to prevent content spillover.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Collapsible drop #1866: Introduced the CollapsibleDropPreview component that this PR refines by adjusting internal measuring wrapper positioning strategy.

Suggested reviewers

  • prxt6529
  • simo6529

Poem

🐰 A hop through the CSS, with precision so neat,
Fixed becomes absolute—the layout's complete!
Overflow contained, no spillage in sight,
Notifications now dance in their boundaries tight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix notifications page flickering and extra bottom height' directly matches the changes made: positioning adjustments and overflow handling in the notifications page to eliminate visual issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch notifications-page-ux-fix

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 4, 2026

@ragnep ragnep merged commit 84a04e5 into main Feb 4, 2026
7 checks passed
@ragnep ragnep deleted the notifications-page-ux-fix branch February 4, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants