Skip to content

add contract remove for emma#1875

Merged
simo6529 merged 3 commits intomainfrom
emma-remove-collection
Feb 3, 2026
Merged

add contract remove for emma#1875
simo6529 merged 3 commits intomainfrom
emma-remove-collection

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Feb 3, 2026

Summary by CodeRabbit

  • New Features

    • Added a delete operation button in the distribution plan tool action menu.
    • Snapshots now include allowlist and ordering information for better sequencing.
  • UX Improvements

    • Improved default tab selection in the Brain content view to more reliably show the appropriate leaderboard/chat.
    • Minor layout tweaks to action rows for more consistent spacing and hover behavior.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Type visibility reduced for an avatar component, two new fields added to snapshot objects and mapped, a delete button added to distribution-plan table rows with layout tweaks, minor config ignore-list updates, and small tab-selection logic simplification.

Changes

Cohort / File(s) Summary
Avatar component
components/common/OverlappingAvatars.tsx
OverlappingAvatarItem type is no longer exported (now internal). No field changes. External imports of that type will break.
Distribution plan — snapshots & table
components/distribution-plan-tool/create-snapshots/CreateSnapshots.tsx, components/distribution-plan-tool/create-snapshots/table/CreateSnapshotTableRow.tsx
CreateSnapshotSnapshot gained allowlistId: string and order: number, populated from createTokenPoolOperation. CreateSnapshotTableRow now includes DistributionPlanDeleteOperationButton alongside the download action and layout wrapper changes affecting DOM structure and styling hooks.
UI tab selection
components/brain/ContentTabContext.tsx
Introduced getDefaultTab(tabs) and simplified Memes-wave default/active tab selection to prefer LEADERBOARD or fallback to CHAT when appropriate.
Config
knip.jsonc
Added entries to ignoreDependencies ("baseline-browser-mapping", "yaml") and minor trailing-comma formatting edits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ragnep
  • prxt6529

Poem

🐇 In code I hop and nibble lines,

Types tucked in cozy vines,
Snapshots sprout two shiny tags,
A delete button joins the flags,
Config commas fall like pines.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'add contract remove for emma' is vague and does not clearly convey the actual changes in the pull request, which involve modifying type exports, adding snapshot fields, updating table components, and refactoring context logic. Revise the title to be more descriptive of the main changes, such as 'Make OverlappingAvatarItem internal and extend CreateSnapshotSnapshot with allowlistId and order fields' or a similar clear summary of the primary modifications.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch emma-remove-collection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@components/distribution-plan-tool/create-snapshots/table/CreateSnapshotTableRow.tsx`:
- Around line 275-283: The delete button currently performs the deletion
immediately when DistributionPlanDeleteOperationButton is clicked; update the UI
so the user must confirm before the API call: modify
DistributionPlanDeleteOperationButton (or wrap it in CreateSnapshotTableRow) to
open a confirmation prompt/modal (or call window.confirm) when clicked and only
invoke the existing delete API/action if the user confirms, preserving the
allowlistId and order props passed from CreateSnapshotTableRow and keeping the
existing success/error handling and any loading state/UX around the deletion.
🧹 Nitpick comments (1)
components/distribution-plan-tool/create-snapshots/CreateSnapshots.tsx (1)

135-137: Consider adding distributionPlan to the dependency array or suppressing the lint warning.

fetchTokenPoolStatuses references distributionPlan but the effect runs only on mount (empty deps). If distributionPlan can be null initially and set later, the fetch won't re-run. If this is intentional (fetch only once after mount), consider adding an eslint-disable comment to clarify intent.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 3, 2026

@simo6529 simo6529 merged commit b954f4e into main Feb 3, 2026
7 checks passed
@simo6529 simo6529 deleted the emma-remove-collection branch February 3, 2026 14:40
simo6529 added a commit that referenced this pull request Feb 3, 2026
* add contract remove for emma

Signed-off-by: Simo <simo@6529.io>

---------

Signed-off-by: Simo <simo@6529.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants