Skip to content

remove animation in gallery for touchscreens#1859

Merged
simo6529 merged 1 commit intomainfrom
leaderboard-slow-at-ipad
Jan 29, 2026
Merged

remove animation in gallery for touchscreens#1859
simo6529 merged 1 commit intomainfrom
leaderboard-slow-at-ipad

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Jan 29, 2026

Summary by CodeRabbit

Release Notes

  • Performance

    • Optimized loading animations on touch-screen devices to reduce unnecessary visual effects and improve responsiveness.
  • UI Improvements

    • Enhanced media gallery and modal component layouts for better touch device compatibility.
    • Minor structural refinements for consistent visual presentation.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Three components are updated to conditionally disable loading pulse animations on touch-screen devices by integrating a device detection hook. Additionally, an unnecessary type cast for voting credit type is removed from the leaderboard component.

Changes

Cohort / File(s) Summary
Touch-device animation detection
components/drops/view/item/content/media/DropListItemContentMediaImage.tsx, components/drops/view/item/content/media/MediaDisplayImage.tsx
Added useDeviceInfo hook to detect touch screens and conditionally apply pulse animation class to loading placeholders; animation is disabled on touch devices. Minor JSX reordering and className adjustments in modal structure.
Type casting removal and transition logic
components/waves/leaderboard/gallery/WaveLeaderboardGalleryItem.tsx
Removed explicit ApiWaveCreditType casting; voting_credit_type now used directly without cast. Inverted transition class calculation logic to align with hasTouchScreen checks. Removed unused ApiWaveCreditType import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ragnep
  • prxt6529
  • analyticsflowee

Poem

🐰 A touch upon the screen, no pulse to see—
The rabbit knows: keep animations free!
One cast removed, the logic turns around,
Device-aware animations, smooth and sound. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'remove animation in gallery for touchscreens' directly summarizes the main change: conditionally disabling pulse animations on touch devices across gallery-related components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@simo6529 simo6529 merged commit 520585b into main Jan 29, 2026
7 checks passed
@simo6529 simo6529 deleted the leaderboard-slow-at-ipad branch January 29, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants