Skip to content

proposed fix for big touchscreen reply#1850

Merged
simo6529 merged 1 commit intomainfrom
big-toucscreen-reply-copy-fix
Jan 28, 2026
Merged

proposed fix for big touchscreen reply#1850
simo6529 merged 1 commit intomainfrom
big-toucscreen-reply-copy-fix

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Jan 28, 2026

Summary by CodeRabbit

  • New Features
    • Improved touch input detection for better mobile device recognition.
    • Added configurable behavior for dropdown visibility on desktop versus touch devices.
    • New actions button now displays on mobile touch interactions for enhanced mobile usability.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Introduces a new useHasTouchInput hook that detects touch input capability across the device. Integrates this hook into CommonDropdownItemsMobileWrapper via a new hideOnDesktopHover prop and into WaveDrop to replace the existing touch-detection mechanism. Updates WaveDropHeader with new props to display and handle mobile action button interactions.

Changes

Cohort / File(s) Summary
New Touch Detection Hook
hooks/useHasTouchInput.ts
New client hook that detects touch input capability by inspecting navigator.maxTouchPoints and subscribing to touchstart events. Returns boolean indicating touch support.
Dropdown Mobile Behavior
components/utils/select/dropdown/CommonDropdownItemsMobileWrapper.tsx
Adds hideOnDesktopHover prop and integrates useHasTouchInput to conditionally apply lg:desktop-hover:tw-hidden class based on computed shouldHideOnDesktopHover state.
Wave Drop Touch Actions
components/waves/drops/WaveDrop.tsx
Replaces useIsTouchDevice with useHasTouchInput; introduces handleOpenTouchActions handler to manage mobile actions panel; updates WaveDropHeader props with showActionsButton and onOpenActions.
Wave Drop Header UI
components/waves/drops/WaveDropHeader.tsx
Adds showActionsButton and onOpenActions props; renders new ellipsis actions button conditionally with icon from heroicons.

Sequence Diagram

sequenceDiagram
    actor User
    participant WaveDrop
    participant useHasTouchInput
    participant WaveDropHeader
    participant ActionPanel

    User->>useHasTouchInput: Check touch capability (navigator.maxTouchPoints or touchstart)
    useHasTouchInput-->>WaveDrop: hasTouchInput (boolean)
    
    WaveDrop->>WaveDrop: Compute showActionsButton based on hasTouchInput
    WaveDrop->>WaveDropHeader: Pass showActionsButton & onOpenActions props
    
    User->>WaveDropHeader: Touch/Click actions button
    WaveDropHeader->>WaveDrop: Trigger onOpenActions (handleOpenTouchActions)
    WaveDrop->>ActionPanel: Open mobile actions panel
    ActionPanel-->>User: Display touch-optimized actions
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • prxt6529

Poem

🐰 Whiskers twitch at touch so fine,
A hook to sense the digits' line,
From phones to tablets, near and far,
We catch each tap like a gentle star,
Mobile magic, sleek and bright,
Touch detection working right!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'proposed fix for big touchscreen reply' accurately reflects the main changes in the PR, which add touch input detection and handling for dropdown/wave components to improve mobile touchscreen interactions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@simo6529 simo6529 merged commit fb1e418 into main Jan 28, 2026
7 checks passed
@simo6529 simo6529 deleted the big-toucscreen-reply-copy-fix branch January 28, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants