Refactor waves list derivation and memoize pinned IDs

[simo6529]

• Simplify useWavesList by removing state/ref/deep-compare logic and deriving allWaves directly from memoized inputs for cleaner, predictable updates.
• Memoize pinnedIds in usePinnedWavesServer to keep stable identities and reduce unnecessary downstream re-renders.
• Keep missingPinnedIds as a stable empty memo and return mainWaves directly from the hook.
• Normalize useWavesList tests with consistent formatting/quotes.

Summary by CodeRabbit

• Tests

  • Enhanced test fixtures with explicit mocking for improved test reliability and clarity.

• Refactor

  • Simplified internal data flow in wave list hook by removing local state and switching to derived data.
  • Added performance optimizations through memoization in pinned waves hook.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

These changes refactor wave list management by replacing local state and refs with memoized derived values. A test file receives quote style standardization and explicit useWaveData mocking. The usePinnedWavesServer hook is enhanced with useMemo for stable pinnedIds derivation.

Changes

Cohort / File(s)	Summary
Test Updates __tests__/hooks/useWavesList.test.tsx	Quote style standardization (single to double quotes), added useWaveData mock in beforeEach to return pinnedExtra with loading/error states, minor formatting adjustments around AuthContext.Provider.
usePinnedWavesServer Enhancement hooks/usePinnedWavesServer.ts	Added useMemo import and derived pinnedIds from pinnedWaves for stable identity across renders.
useWavesList Refactoring hooks/useWavesList.ts	Removed broad React imports (now only useContext, useMemo, useCallback); eliminated deep equality helper and local state/refs (allWaves, previous snapshots); introduced memoized derived allWaves by merging mainWaves and separatelyFetchedPinnedWaves; computed isPinned from pinnedIds set; replaced useEffect-based eager updates with derived data patterns; exposed mainWaves in return object; simplified logic and comments.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• PR #1746: Modifies isPinned representation and computation—main PR derives isPinned from pinnedIds in useWavesList while retrieved PR adds EnhancedApiWave.isPinned in mapWave.
• PR #1669: Modifies hooks/usePinnedWavesServer.ts pinned-waves handling—one derives pinnedIds with useMemo while the other adds refetchInterval.
• PR #1823: Modifies hooks/useWavesList.ts with opposite pattern—retrieved PR adds state/refs/useEffect while main PR removes them in favor of memoized derived values.

Suggested reviewers

• ragnep
• GelatoGenesis

Poem

🐰 Memoize, oh memoize, the waves must flow,
No refs, no state, just derived data's glow!
Pinned IDs dance in memo's embrace,
Clean data streams, a refactored space!
From eager updates to lazy delights,
The hooks sing true through performance heights! 🌊✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: refactoring waves list derivation and memoizing pinned IDs, which are the core objectives of the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud