Skip to content

tab longpress fix#1768

Merged
simo6529 merged 1 commit intomainfrom
simo6529/tab-drop-menu
Jan 20, 2026
Merged

tab longpress fix#1768
simo6529 merged 1 commit intomainfrom
simo6529/tab-drop-menu

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Jan 20, 2026

Summary by CodeRabbit

  • Refactor
    • Updated dropdown component's internal structure and styling for better layout consistency
    • Fine-tuned responsive design classes and minor spacing adjustments to align with updated design tokens

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

This pull request updates a dropdown component to use newer Headless UI composite components, replacing Transition.Root with Transition and Dialog.Panel with DialogPanel. Tailwind class names are adjusted to reflect responsive prefixes, and minor structural reordering is applied to accommodate the updated component hierarchy.

Changes

Cohort / File(s) Summary
Headless UI Component Migration
components/utils/select/dropdown/CommonDropdownItemsMobileWrapper.tsx
Updated Transition and Dialog imports to use composite components (Transition.Root → Transition, Transition.Child → TransitionChild, Dialog → DialogPanel/DialogTitle). Adjusted Tailwind classes including responsive prefixes (lg:desktop-hover utilities) and reordered layout properties (margins, padding, flex/grid). Minor structural changes to close button and content container positioning.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a skip, components align,
New composite partners in design,
Transitions smooth and dialogs bright,
This dropdown now feels just right!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'tab longpress fix' is vague and does not clearly describe the actual changes made. The PR primarily updates Headless UI component usage (Transition and Dialog) with new composite components, adjusts class names, and modifies layout structure—none of which directly relate to 'tab longpress' functionality. Revise the title to accurately reflect the main change, such as 'Update CommonDropdownItemsMobileWrapper to use new Headless UI composite components' or 'Refactor dropdown mobile wrapper with Transition and Dialog updates'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@simo6529 simo6529 merged commit dc67060 into main Jan 20, 2026
7 checks passed
@simo6529 simo6529 deleted the simo6529/tab-drop-menu branch January 20, 2026 12:54
@coderabbitai coderabbitai Bot mentioned this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants