Skip to content

fix build#1767

Merged
simo6529 merged 1 commit intomainfrom
simo6529/marseille
Jan 20, 2026
Merged

fix build#1767
simo6529 merged 1 commit intomainfrom
simo6529/marseille

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Jan 20, 2026

Summary by CodeRabbit

  • Refactor
    • Simplified touch detection handling in participation components by removing unnecessary prop forwarding.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

A single prop (hasTouch) has been removed from the ParticipationDropContent component invocation in the OngoingParticipationDrop component. This eliminates the forwarding of touch-detection information to the child component without introducing additional logic or control-flow modifications.

Changes

Cohort / File(s) Summary
Touch prop removal
components/waves/drops/participation/OngoingParticipationDrop.tsx
Removed hasTouch prop passed to ParticipationDropContent child component

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ipad long press fix #1766: Removes hasTouch prop wiring to the same ParticipationDropContent component, indicating prior related changes to the component's touch-detection prop interface.

Poem

🐰 A touch too much, we gently say,
One prop removed, now swept away,
The drop stays light, the code flows clean,
No hasTouch needed in between! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix build' is vague and generic, providing no meaningful information about the specific change made to the codebase. Consider using a more descriptive title that explains what build issue was fixed, such as 'Remove hasTouch prop from ParticipationDropContent' or 'Fix build by removing unused hasTouch prop'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@simo6529 simo6529 merged commit b438dd6 into main Jan 20, 2026
7 checks passed
@simo6529 simo6529 deleted the simo6529/marseille branch January 20, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants