Skip to content

Raise pinned waves limit to 20#1754

Merged
simo6529 merged 1 commit intomainfrom
simo6529/curitiba
Jan 19, 2026
Merged

Raise pinned waves limit to 20#1754
simo6529 merged 1 commit intomainfrom
simo6529/curitiba

Conversation

@simo6529
Copy link
Copy Markdown
Collaborator

@simo6529 simo6529 commented Jan 19, 2026

Summary by CodeRabbit

Release Notes

  • Improvements
    • Increased the maximum number of waves that can be pinned from 10 to 20, enabling broader content curation
    • Enhanced pinned waves feature with improved data management and lifecycle handling for greater stability
    • Pinned waves are now properly cleared upon logout to maintain data consistency

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Simo <simo@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

The PR increases the maximum pinned waves limit from 10 to 20 across implementation and test files while enhancing the server hook with improved query lifecycle management, explicit type parameters, a new refetch return type, logout data clearing, and refined optimistic update logic.

Changes

Cohort / File(s) Summary
Configuration Updates
hooks/usePinnedWaves.tsx, __tests__/hooks/usePinnedWaves.test.tsx
Increased MAX_PINNED_WAVES constant from 10 to 20 in both the hook implementation and its corresponding test, adjusting loop bounds and assertions.
Server Hook Enhancements
hooks/usePinnedWavesServer.ts
Expanded MAX_PINNED_WAVES to 20; updated refetch return type to Promise<QueryObserverResult<ApiWave[], Error>>; added query lifecycle options (enabled, staleTime, gcTime, refetchInterval); improved logout handling via queryClient.setQueryData; refined optimistic update traversal logic for WAVES_OVERVIEW queries; added explicit type parameters for query data access; standardized error message formatting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Pinned sync #1669: Introduces periodic refetch behavior via refetchInterval in query lifecycle, directly related to the query configuration enhancements in this PR.

Suggested reviewers

  • ragnep
  • prxt6529

Poem

🐰 The waves now dance in numbers grand,
Twenty strong across the land,
With queries swift and data clear,
The pinned collection holds them dear! 📌✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Raise pinned waves limit to 20' directly and clearly summarizes the main change across all modified files: increasing MAX_PINNED_WAVES from 10 to 20.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@simo6529 simo6529 merged commit ac51d37 into main Jan 19, 2026
7 checks passed
@simo6529 simo6529 deleted the simo6529/curitiba branch January 19, 2026 09:35
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants