Skip to content

Meme Submissions - Promo video#1742

Merged
prxt6529 merged 5 commits intomainfrom
meme-submission-promo-video
Jan 15, 2026
Merged

Meme Submissions - Promo video#1742
prxt6529 merged 5 commits intomainfrom
meme-submission-promo-video

Conversation

@prxt6529
Copy link
Copy Markdown
Collaborator

@prxt6529 prxt6529 commented Jan 15, 2026

Summary by CodeRabbit

  • New Features

    • Promo video support for submissions (upload, preview, and management).
    • Promo videos appear in drop details with playback and a download option.
  • Bug Fixes

    • User avatar images now resolve correctly before rendering.
    • Overlay stacking order adjusted to ensure drop overlays display above other UI.
  • Tests

    • Added/updated tests covering promo video behavior and IPFS URL resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: prxt6529 <prxt@6529.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Adds promo video support across submission and display: extends AdditionalMedia with promo_video, wires upload/preview/URL parsing through submission components, exposes getDropPromoVideoUrl, updates drop display to show a Promo Video block, and resolves IPFS URLs for avatars in header tests.

Changes

Cohort / File(s) Summary
Types & Form State
components/waves/memes/submission/types/OperationalData.ts, components/waves/memes/submission/hooks/useArtworkSubmissionForm.ts
Added promo_video: string to AdditionalMedia and initialized additional_media.promo_video in form state.
Submission Container & Flow
components/waves/memes/submission/MemesArtSubmissionContainer.tsx
Added handlePromoVideoChange, introduced mediaTypeInfo with isInteractive, computed preview requirements, and forwarded promo video props down the flow.
Submission Step & Upload UI
components/waves/memes/submission/steps/AdditionalInfoStep.tsx, components/waves/memes/submission/components/AdditionalMediaUpload.tsx
Added props promoVideo, requiresPromoVideoOption, onPromoVideoChange; added promo video refs/upload handling, server URL sync effect, and a Promo Video UI section; adjusted preview labeling/text.
Drop Parsing & Display
helpers/waves/drop.helpers.ts, components/waves/drop/WaveDropAdditionalInfo.tsx, components/waves/drop/MemesSingleWaveDropInfoPanel.tsx
Added exported getDropPromoVideoUrl; parse promo_video from AdditionalMedia; render promo video element and promo-video details row in drop info; memoized promoVideoData for downloads.
Header / Avatar IPFS resolution
components/header/AppHeader.tsx, __tests__/components/header/AppHeader.test.tsx
AppHeader avatar Image source now uses resolveIpfsUrlSync; tests mock IPFS context resolver.
Overlay z-index adjustments
components/brain/BrainMobile.tsx, components/shared/WavesMessagesWrapper.tsx
Increased overlay z-index values for drop overlays.
Tests updated/added
__tests__/components/waves/drop/WaveDropAdditionalInfo.test.tsx, __tests__/components/waves/memes/submission/components/AdditionalMediaUpload.test.tsx, __tests__/helpers/waves/drop.helpers.test.ts
Updated headings/labels; added tests for promo video parsing, rendering, and promoVideo-related upload UI behavior.

Sequence Diagram

sequenceDiagram
    actor User
    participant UploadUI as AdditionalMediaUpload
    participant Step as AdditionalInfoStep
    participant Container as MemesArtSubmissionContainer
    participant Form as useArtworkSubmissionForm
    participant Server as UploadServer

    User->>UploadUI: Selects promo video file
    UploadUI->>Server: Upload file -> returns serverUrl
    Server-->>UploadUI: serverUrl
    UploadUI->>Step: onPromoVideoChange(serverUrl)
    Step->>Container: forwards promoVideo change
    Container->>Form: handlePromoVideoChange -> update additional_media.promo_video
    Container->>Step: pass promoVideo prop for preview
    Step->>UploadUI: render promo video preview using serverUrl
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • simo6529
  • GelatoGenesis
  • ragnep

Poem

🐰 A rabbit hops with a joyful cheer,
Promo clips now hop right here.
Upload, parse, and IPFS-bound,
Videos play and downloads found.
Hooray—small changes, big delight! 🎬

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Meme Submissions - Promo video' directly describes the main feature addition across the changeset: promo video support for meme submissions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96a27bd and c5ab262.

📒 Files selected for processing (2)
  • components/brain/BrainMobile.tsx
  • components/shared/WavesMessagesWrapper.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • components/brain/BrainMobile.tsx
  • components/shared/WavesMessagesWrapper.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: prxt6529 <prxt@6529.io>
Signed-off-by: prxt6529 <prxt@6529.io>
Signed-off-by: prxt6529 <prxt@6529.io>
Signed-off-by: prxt6529 <prxt@6529.io>
@sonarqubecloud
Copy link
Copy Markdown

@prxt6529 prxt6529 merged commit 5dc9a89 into main Jan 15, 2026
7 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants