last drop time fix

[simo6529]

Summary by CodeRabbit

• Refactor
  • More consistent and accurate time labels across the UI via an updated timestamp update mechanism.
  • Time labels now refresh when the displayed reference time changes, ensuring visible age indicators stay up to date.

[coderabbitai]

Walkthrough

A component's time tracking is refactored from a tick counter to a timestamp state updated via window.setInterval/clearInterval, with an effect to sync on prop changes; the time-format helper now accepts an optional referenceTime parameter so callers can supply the component's tracked timestamp.

Changes

Cohort / File(s)	Summary
Time state & interval refactor components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx	Reorders React imports, replaces local tick state with now timestamp initialized to Date.now(), uses window.setInterval to update now each minute and window.clearInterval on cleanup, adds effect to sync now when time prop changes, computes a label via getTimeAgoShort(time, now) and renders it.
Helper signature change helpers/Helpers.ts	Changes getTimeAgoShort(milliseconds: number) → getTimeAgoShort(milliseconds: number, referenceTime: number = Date.now()) and uses referenceTime - milliseconds for the time difference calculation.

Sequence Diagram

sequenceDiagram
    participant Comp as BrainLeftSidebarWaveDropTime
    participant Timer as window.setInterval
    participant Helper as getTimeAgoShort
    participant Render as React Render

    Comp->>Comp: now = Date.now() (init)
    Comp->>Timer: setInterval(callback, 60000)
    Note right of Timer: Callback runs every minute
    loop every minute
        Timer->>Comp: invoke callback
        Comp->>Comp: now = Date.now() (update)
        Comp->>Helper: getTimeAgoShort(time, now)
        Helper-->>Comp: label (computed with referenceTime)
        Comp->>Render: re-render with label
    end
    alt on prop `time` change
        Component->>Component: effect updates now = Date.now()
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas needing extra attention:
  • Interval setup/teardown correctness (use of window.setInterval/clearInterval and dependency list).
  • Effect that syncs now on time prop changes to ensure no stale labels.
  • Calls to getTimeAgoShort across the codebase that may rely on the previous single-argument signature (confirm default parameter covers them).

Poem

🐰
From ticks to now I softly hop,
I watch the minutes gently drop,
A timestamp held, a label sings—
Time measured by sure little springs,
The meadow marks each passing hop.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'last drop time fix' is specific and directly reflects the main change: fixing how drop time is calculated by introducing a reference time parameter to getTimeAgoShort and synchronizing it across the component.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch last-drop-ts-fix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd1169c and b200271.

📒 Files selected for processing (1)

• components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c79285 and fd1169c.

📒 Files selected for processing (2)

• components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx (2 hunks)
• helpers/Helpers.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{ts,tsx}: Do not include any comments in the code
Use react-query for data fetching
Always add readonly before props

Files:

• components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx
• helpers/Helpers.ts

**/*.tsx

📄 CodeRabbit inference engine (.cursorrules)

**/*.tsx: Use FontAwesome for icons
Use TailwindCSS for styling

Files:

• components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx

🧬 Code graph analysis (1)

components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx (2)

helpers/time.ts (1)

• now (7-9)

helpers/Helpers.ts (1)

• getTimeAgoShort (563-589)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

helpers/Helpers.ts (1)

563-567: LGTM! Improved testability and backward compatibility.

The addition of the optional referenceTime parameter enhances testability while maintaining backward compatibility through the default value. This allows callers to pass a consistent reference timestamp for multiple time calculations, which aligns well with the component changes in BrainLeftSidebarWaveDropTime.tsx.

components/brain/left-sidebar/waves/BrainLeftSidebarWaveDropTime.tsx (2)

13-13: Good use of function initializer.

Using () => Date.now() ensures the initial timestamp is computed only once during component mount, which is the correct pattern for expensive or time-sensitive initialization.

---

25-27: LGTM! Clean time calculation with explicit reference.

Passing the now state to getTimeAgoShort makes the time calculation explicit and enables consistent rendering. The refactor from a tick counter to a timestamp state is semantically clearer while maintaining the same update frequency.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud