-
Notifications
You must be signed in to change notification settings - Fork 5
App ui/ux fixes #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
App ui/ux fixes #1582
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| --- | ||
| created: 2025-10-29 | ||
| id: TKT-0035 | ||
| owner: openai-assistant | ||
| priority: P1 | ||
| status: In-Progress | ||
| title: Add Discover link to app sidebar navigation | ||
| --- | ||
|
|
||
| ## Context | ||
|
|
||
| > The in-app sidebar navigation omits a link to the Discover experience, forcing users to rely on deep links or browser navigation. Restoring parity with the web sidebar should improve discoverability and align the app's UX. While iterating on these navigation fixes, we also spotted inconsistent search icons in the app waves and identity search inputs that should be updated to the shared Heroicons set. | ||
|
|
||
| ## Plan | ||
|
|
||
| - [x] Audit the app sidebar component to confirm available navigation slots and icon usage. | ||
| - [x] Inject a Discover entry pointing to the existing Discover route with consistent styling and ordering. | ||
| - [ ] Validate navigation manually and adjust tests or stories if they cover sidebar entries. | ||
| - [ ] Update `WavesListSearch` and the identity search form to use the Heroicons search glyph. | ||
| - [ ] Ensure relevant tests reflect the updated icon rendering. | ||
|
|
||
| ## Acceptance | ||
|
|
||
| - [ ] App sidebar includes a Discover item that routes to the Discover page. | ||
| - [ ] Sidebar highlight state updates correctly when visiting Discover. | ||
| - [ ] Waves list and identity search inputs render the Heroicons search icon consistently. | ||
| - [ ] `npm run lint`, `npm run type-check`, and targeted tests for the sidebar/search components pass locally. | ||
|
|
||
| ## Links | ||
|
|
||
| - Primary PR: _(add when available)_ | ||
| - Follow-ups: _(reference additional tickets or TODO items)_ | ||
|
|
||
| ## Log | ||
|
|
||
| - 2025-10-29T11:47:41Z – Created ticket and captured initial scope for restoring Discover navigation entry. | ||
| - 2025-10-29T11:50:40Z – Added Discover link to app sidebar and reordered Network section ahead of Tools. | ||
| - 2025-10-29T12:03:31Z – Expanded ticket scope to align waves and identity search icons with Heroicons. | ||
| - 2025-10-29T12:04:31Z – Swapped both waves and identity search fields to use the shared Heroicons magnifier glyph. | ||
| - 2025-10-29T12:20:49Z – Reinstated the `useRounded` option on `WaveHeader` per design confirmation. | ||
| - 2025-10-29T12:29:35Z – Made the drop overlay full-screen in the app shell and added safe-area padding to the mobile drop header. | ||
| - 2025-10-29T12:31:32Z – Offset the drop close button using safe-area-aware positioning. | ||
| - 2025-10-29T12:48:26Z – Tweaked `WaveItem` card aspect/gradient heights to reduce hero image height on small screens. | ||
| - 2025-10-29T12:50:55Z – Added a loading state and disabled interaction for the Waves “Show all” toggle to avoid jarring label flips. | ||
| - 2025-10-29T12:53:25Z – Brightened the “Show less” state and added directional icons so the toggle remains obvious after expansion. | ||
| - 2025-10-29T13:02:20Z – Reverted `WavesListWrapper` UI experiments; restored original toggle styling and behavior. | ||
| - 2025-10-29T13:03:41Z – Added `readonly` to `BrainMobile` props to align with the TypeScript conventions. | ||
| - 2025-10-29T13:04:31Z – Swapped the drop close SVG for the shared Heroicons `XMarkIcon` component. | ||
| - 2025-10-29T13:16:24Z – Adjusted mobile drop header spacing while verifying safe-area offsets. | ||
| - 2025-10-29T13:22:31Z – Detached `SingleWaveDropChat` from `LayoutContext` so the overlay no longer reserves extra space for the AppHeader. | ||
| - 2025-10-29T13:24:18Z – Reverted that change after it regressed the drop layout. | ||
| - 2025-10-29T13:26:58Z – Switched the typing indicator background to a Tailwind gradient (bottom-up) for smoother blending. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.