Improved hash space and expressivity #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all random data came from Python’s built-in UUID4 encoded in hexadecimal. Hexadecimal encodes 16 values in one byte, that means there is a 4:8 ratio of meaningful bits to each byte of hexadecimal encoding. Instead we use base64 which encodes at a 6:8 ratio. This has the added benefit of not looking amateurish.
|
Also it should be 90% backward-compatible. |
|
All new API keys will have the larger hash space and more expressive encoding; all old ones will still work. I haven't tried migrating a UUID field in PostgreSQL and would suspect that the conversion isn't painless. What happens in psql if you alter a column type from uuid to varchar? Will it simply be hexadecimal? |
|
Reworded the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all random data came from Python’s built-in UUID4 encoded in
hexadecimal. Hexadecimal encodes 16 values in one byte, that means there
is a 4:8 ratio of meaningful bits to each byte of hexadecimal encoding.
Instead we use base64 which encodes at a 6:8 ratio. This has the added
benefit of looking better.