Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed mistakes in README.md and changed exported rules #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Example:
```
//examples:test_config_yml

load("//prometheus:defs.bzl", "promtool_config_test")
load("@io_bazel_rules_prometheus//prometheus:defs.bzl", "promtool_config_test")
promtool_config_test(
name = "test_config_yml",
srcs = ["prometheus.yml"],
Expand Down Expand Up @@ -120,7 +120,7 @@ Example:
```
//examples:unit_test_rules_yml

load("//prometheus:defs.bzl", "promtool_unit_test")
load("@io_bazel_rules_prometheus//prometheus:defs.bzl", "promtool_unit_test")
promtool_unit_test(
name = "unit_test_rules_yml",
srcs = [
Expand Down Expand Up @@ -163,7 +163,7 @@ Tool will have access to workspace. It is intended for convenient in-workspace u

Example:
```
load("//prometheus:defs.bzl", "prometheus")
load("@io_bazel_rules_prometheus//prometheus:defs.bzl", "prometheus")

package(default_visibility = ["//visibility:public"])

Expand Down Expand Up @@ -198,7 +198,7 @@ This rule will emit runnable sh_binary target which will invoke promtool binary
Example:
```
//:promtool
load("//prometheus:defs.bzl", "promtool")
load("@io_bazel_rules_prometheus//prometheus:defs.bzl", "promtool")

package(default_visibility = ["//visibility:public"])

Expand Down
4 changes: 4 additions & 0 deletions prometheus/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ load(
load(
"@io_bazel_rules_prometheus//prometheus/internal:prom.bzl",
_prometheus = "prometheus",
_prometheus_server="prometheus_server",
)


load(
"@io_bazel_rules_prometheus//prometheus/internal:toolchain.bzl",
_prometheus_toolchains = "prometheus_toolchains",
Expand All @@ -25,3 +28,4 @@ promtool_config_test = _promtool_config_test
promtool = _promtool
promtool_rules_test = _promtool_rules_test
prometheus = _prometheus
prometheus_server = _prometheus_server