Skip to content

FEAT: The enable cookies option for JavaScriptBuilderElement is now configurable per-request. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 4, 2024
Merged

FEAT: The enable cookies option for JavaScriptBuilderElement is now configurable per-request. #41

merged 12 commits into from
Jun 4, 2024

Conversation

@ben51degrees
Copy link
Contributor

@ben51degrees ben51degrees commented May 31, 2024

Closes #38

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Unit Tests - Ubuntu_PHP_8.0

40 tests   39 ✅  0s ⏱️
 9 suites   1 💤
 1 files     0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Unit Tests - Ubuntu_PHP_8.3

40 tests   39 ✅  0s ⏱️
 9 suites   1 💤
 1 files     0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Unit Tests - Ubuntu_PHP_8.1

40 tests   39 ✅  0s ⏱️
 9 suites   1 💤
 1 files     0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Unit Tests - Ubuntu_PHP_7.4

40 tests   39 ✅  0s ⏱️
 9 suites   1 💤
 1 files     0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Integration Tests - Ubuntu_PHP_8.0

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Unit Tests - Ubuntu_PHP_8.2

40 tests   39 ✅  0s ⏱️
 9 suites   1 💤
 1 files     0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Integration Tests - Ubuntu_PHP_8.3

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Integration Tests - Ubuntu_PHP_8.1

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Integration Tests - Ubuntu_PHP_7.4

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Integration Tests - Ubuntu_PHP_8.2

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Performance Tests - Ubuntu_PHP_8.0

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Performance Tests - Ubuntu_PHP_8.3

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Performance Tests - Ubuntu_PHP_8.1

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Performance Tests - Ubuntu_PHP_8.2

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Performance Tests - Ubuntu_PHP_7.4

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ec9ef7.

♻️ This comment has been updated with latest results.

@justadreamer
Copy link
Contributor

justadreamer commented Jun 3, 2024 •
edited
Loading

Hi @ben51degrees PHP is a bit different than other APIs in how it integrates javascript-template - it does not use a submodule, it ships the template code directly as part of the repo and uses Nightly Package Update workflow to automatically update it. The reason for this is that submodules are poorly supported by composer - it requires all code needed be in the repository itself. This is reflected in the README to this repo, but perhaps not clearly - we'll provide more context. Thus please revert switching javascript-template to submodule :)

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Tests - macOS_PHP_8.3

40 tests  +40   39 ✅ +39   0s ⏱️ ±0s
 9 suites + 9    1 💤 + 1 
 1 files   + 1    0 ❌ ± 0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Tests - macOS_PHP_7.4

40 tests  +40   39 ✅ +39   0s ⏱️ ±0s
 9 suites + 9    1 💤 + 1 
 1 files   + 1    0 ❌ ± 0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Tests - macOS_PHP_8.1

40 tests  +40   39 ✅ +39   0s ⏱️ ±0s
 9 suites + 9    1 💤 + 1 
 1 files   + 1    0 ❌ ± 0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Tests - macOS_PHP_8.0

40 tests  +40   39 ✅ +39   0s ⏱️ ±0s
 9 suites + 9    1 💤 + 1 
 1 files   + 1    0 ❌ ± 0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Tests - macOS_PHP_8.2

40 tests  +40   39 ✅ +39   0s ⏱️ ±0s
 9 suites + 9    1 💤 + 1 
 1 files   + 1    0 ❌ ± 0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Integration Tests - macOS_PHP_8.2

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Performance Tests - macOS_PHP_8.2

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Integration Tests - macOS_PHP_7.4

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Performance Tests - macOS_PHP_7.4

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@justadreamer justadreamer mentioned this pull request Jun 4, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

Integration Tests - macOS_PHP_8.0

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

Performance Tests - macOS_PHP_8.0

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

Integration Tests - macOS_PHP_8.1

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

Integration Tests - macOS_PHP_8.3

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

Performance Tests - macOS_PHP_8.1

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

Performance Tests - macOS_PHP_8.3

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8ec9ef7. ± Comparison against base commit 460acca.

@Automation51D Automation51D merged commit 2edec5a into main Jun 4, 2024
@Automation51D Automation51D deleted the feature/cookies branch June 4, 2024 15:54
@ben51degrees ben51degrees mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Per-Detection Configuration of Enable/Disable Cookies

4 participants

@ben51degrees @justadreamer @Automation51D