FEAT: Added descriptive title to git tag, if one is available. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pi-alexander-popel
left a comment
pi-alexander-popel
left a comment
There was a problem hiding this comment.
If they ever get a version branch with a -suffix, this will break repositories that have strict requirements for the versions format (like Python), and even those that don't might not sort the resulting version correctly (like Maven).
Maybe it's better to do this just in repositories that need it now, instead of globally. For an example see:
https://github.com/51Degrees/ip-intelligence-dotnet/blob/main/ci/get-next-package-version.ps1
https://github.com/51Degrees/ip-intelligence-dotnet/blob/main/GitVersion.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitVersion config now has 2 separate alpha branch configs.
One which is used if a pattern like
version/0.0.0-descriptionis found,and the existing one if a pattern like
version/0.0.0is found.