Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AndroidX + make RecyclerView.canScrollVerticall(-1) work #53

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

mck182
Copy link
Contributor

@mck182 mck182 commented Jan 14, 2020

This PR migrates the whole project to AndroidX
and implements two scrolling offset calculations
functions - computeVerticalScrollOffset(..) and
computeVerticalScrollRange(..) which in turn
makes RecyclerView.canScrollVerticall(-1) work.

Martin Klapetek added 4 commits January 14, 2020 11:56
…nge(..)

This should now support recyclerView.canScrollVertically(-1) calls, ie.
"is the recyclerview at the top"
@mck182 mck182 requested a review from Anenha January 14, 2020 17:07
Copy link
Contributor

@Anenha Anenha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@mck182 mck182 merged commit d29bbe1 into master Jan 14, 2020
@mck182 mck182 deleted the implement-canscrollvertically branch January 14, 2020 18:13
@mck182 mck182 mentioned this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants