feat: 이전 메시지 불러오기 - #94
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Obebe-creator
changed the title
|
Warning Review limit reached
Next review available in: 42 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough채팅 모달이 전용 메시지 스크롤 컨테이너를 사용하도록 변경되었습니다. 새 메시지는 Changes채팅 메시지 스크롤 및 표시
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/chat/ChatRoomModalContainer.tsx (1)
63-64: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win사용하지 않는 sentinel ref를 제거해 주세요.
자동 스크롤은
scrollContainerRef를 사용하므로bottomRef는 읽히지 않습니다. Line 64의 ref와 Line 168의 연결 코드를 제거하면 stale sentinel을 없애고 구현 의도를 명확하게 유지할 수 있습니다.정리 예시
@@ - const bottomRef = useRef<HTMLDivElement | null>(null); @@ - <div ref={bottomRef} aria-hidden="true" />Also applies to: 168-168
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/chat/ChatRoomModalContainer.tsx` around lines 63 - 64, Remove the unused bottomRef sentinel from ChatRoomModalContainer, including its useRef declaration and the JSX ref connection near the bottomRef usage. Keep scrollContainerRef and the existing automatic-scroll behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/chat/ChatRoomModalContainer.tsx`:
- Around line 109-127: 분리 이전 메시지 버튼을 감싸는 상단 영역을 추가해 `hasNextPage`일 때 목록 상단에
배치하세요. `ChatRoomModalContainer`의 메시지 컨테이너에만 `min-h-full`과 `justify-end` 또는
`mt-auto`가 적용되도록 구조를 변경해, 버튼이 하단 정렬 그룹에 포함되지 않게 하세요.
- Around line 109-110: Update the scroll container div identified by
scrollContainerRef to add tabIndex={0} and an accessible-name-bearing
role="region", while preserving its existing overflow behavior and focus styling
so keyboard users can focus the conversation area and scroll it with
PageUp/PageDown.
---
Nitpick comments:
In `@src/components/chat/ChatRoomModalContainer.tsx`:
- Around line 63-64: Remove the unused bottomRef sentinel from
ChatRoomModalContainer, including its useRef declaration and the JSX ref
connection near the bottomRef usage. Keep scrollContainerRef and the existing
automatic-scroll behavior unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b47c4d0e-2c9a-43dc-be02-6aaf9e492bb1
📒 Files selected for processing (2)
src/components/chat/ChatRoomModal.tsxsrc/components/chat/ChatRoomModalContainer.tsx
1 participant
📋 작업 내용
🔥 변경 사항
overflow-hidden으로 제한하고, 메시지 리스트가 직접 스크롤 컨테이너를 갖도록 변경했습니다.scrollContainerRef기준으로 처리하도록 수정했습니다.aria-busy상태를 표시하도록 했습니다.✅ 체크리스트
📷 스크린샷 (선택)
🔗 관련 이슈
Closes #
💬 To Reviewer
Summary by CodeRabbit