[FIX] 채팅방 실패 상태 입력 영역 비활성화 - #89
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough채팅방 생성 또는 조회가 완료되기 전 Changes채팅 컴포저 상태
생성 오류 UI 조정
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant ChatRoomModalContainer
participant ChatRoomModal
participant ActionMenu
participant MessageInput
ChatRoomModalContainer->>ChatRoomModal: composerDisabled 전달
ChatRoomModal->>ActionMenu: 비활성화 및 aria 상태 적용
ChatRoomModal->>MessageInput: 입력 및 전송 비활성화
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/chat/ChatRoomModal.tsx`:
- Line 51: `ChatRoomModal`의 + 버튼과 전송 버튼에 비활성화 전용 배경·텍스트·테두리 토큰을 함께 적용하세요.
`isSendDisabled`가 사용하는 두 버튼의 class 조합에서 기존 disabled 배경 스타일을 유지하고 disabled 텍스트 및
테두리 스타일을 추가하며, 입력창의 `disabled:text-text-muted`와 `bg-background-subtle` 스타일은 변경하지
마세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c5759fea-a36b-465f-a17d-5495db52836a
📒 Files selected for processing (3)
src/components/chat/ChatRoomCreateError.tsxsrc/components/chat/ChatRoomModal.tsxsrc/components/chat/ChatRoomModalContainer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 작업 내용
🔥 변경 사항
ChatRoomCreateError의 info 표시를 Figma 시안에 맞게 연한 원형 배경 +i형태로 조정했습니다.ChatRoomModal에composerDisabledprop을 추가했습니다.composerDisabled상태에서+메뉴, 메시지 input, 전송 버튼이 동작하지 않도록 처리했습니다.aria-expanded값이 일치하도록 정리했습니다.composerDisabled를 전달하도록 연결했습니다.✅ 체크리스트
📷 스크린샷 (선택)
🔗 관련 이슈
Closes #
💬 To Reviewer
+메뉴, 메시지 입력, 전송 버튼이 모두 비활성화되는지 중점적으로 확인 부탁드립니다.Summary by CodeRabbit
새 기능
스타일 개선