refactor: 기사기능 페이지 리팩토링 - #82
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 47 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough견적 관련 페이지의 텍스트 로딩 상태를 반응형 스켈레톤 UI로 교체했습니다. 인증 fallback에도 페이지별 스켈레톤을 연결했습니다. 받은 요청 수 영역에도 로딩 스켈레톤을 적용했습니다. 완료된 견적 카드의 스타일과 표시 내용을 조정했습니다. Changes견적 로딩 UI
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yooseohyeon
left a comment
yooseohyeon
left a comment
There was a problem hiding this comment.
작업하시느라 수고하셨습니다! 공용 Skeleton을 잘 조합했고, 카드/페이지 레이아웃도 기존 UI에 맞춰 구성했습니다.
아래는 그냥 소소한 의견입니다!
견적 완료 여부에 상관 없이 견적 카드 클릭 시 견적 상세 페이지로 이동하게 되면서, 완료 견적 카드에서도 카드 전체 클릭으로 바꾸고 "견적 상세보기” 버튼을 없애신 의도를 이해했습니다 또한 카드 hover 시 효과를 추가하신 점도 좋았습니다. 하지만 오버레이 때문에 클릭 가능한 요소임이 시각적으로 덜 드러날 수도 있을 것 같습니다. 이건 제 주관적인 느낌일 수도 있고, 오버레이를 사용하지 않는 경우 다른 방식으로 완료 여부를 알려야하기 때문에 아주 나중에 고려해봐도 될 사항인 것 같습니다.
…into refactor/mover-estimate
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/estimate/MoverEstimateListSkeleton.tsx`:
- Around line 41-45: 각 스켈레톤 로딩 컨테이너에 상태 역할을 추가하세요.
src/components/estimate/MoverEstimateListSkeleton.tsx#L41-L45의 목록 컨테이너와
src/components/estimate/ReceivedRequestsSkeleton.tsx#L42-L45의 받은 요청 컨테이너에
role="status"를 추가하고, 기존 aria-label 및 aria-busy 속성은 유지하세요.
In `@src/components/estimate/ReceivedRequestsSkeleton.tsx`:
- Around line 32-35: Replace the arbitrary gap-[11px] utility in the
ReceivedRequestsSkeleton layout with the existing spacing token utility, such as
gap-12, while preserving the current responsive grid and skeleton structure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3dd4c9ba-61e3-450d-8749-b5919a5743dc
📒 Files selected for processing (10)
src/app/estimate/received-requests/page.tsxsrc/app/estimate/rejected/page.tsxsrc/app/estimate/sent/page.tsxsrc/components/estimate/MoverEstimateListSkeleton.tsxsrc/components/estimate/ReceivedRequestsPage.tsxsrc/components/estimate/ReceivedRequestsSkeleton.tsxsrc/components/estimate/RejectedRequestsPage.tsxsrc/components/estimate/sent/SentEstimateCard.tsxsrc/components/estimate/sent/SentEstimatesPage.tsxsrc/lib/loading/getMoverProtectedLoadingFallback.tsx
2 participants
📋 작업 내용
🔥 변경 사항
✅ 체크리스트
📷 스크린샷 (선택)
🔗 관련 이슈
Closes #
💬 To Reviewer
Summary by CodeRabbit
새로운 기능
개선