feat: 견적 상세 페이지의 공유 기능 제거 - #50
Merged
Merged
Conversation
📝 WalkthroughWalkthrough견적 상세 페이지의 동적 메타데이터와 견적 공유 기능을 제거했습니다. 기사 상세 페이지에는 Changes견적 및 기사 상세 공유 변경
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant MoverDetailView
participant MoverDetailShare
participant usePageShare
participant shareKakaoMoverCustom
MoverDetailView->>MoverDetailShare: kakaoShare 및 onToastMessage 전달
MoverDetailShare->>usePageShare: 링크 복사 요청
MoverDetailShare->>shareKakaoMoverCustom: 기사 공유 templateArgs 전달
shareKakaoMoverCustom-->>MoverDetailShare: 성공 또는 오류 콜백
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/mover/detail/MoverDetailShare.tsx (1)
11-30: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win공유 아이콘을 공통 아이콘으로 분리하세요.
src/icons/index.ts에는 카카오 공유 아이콘과 Facebook 아이콘이 없습니다.KakaoLoginIcon은 로그인용 로고라서 현재 공유 아이콘을 대체할 수 없습니다. 현재 SVG를src/icons의 아이콘으로 이동하고src/icons/index.ts에서 export한 뒤,interface기반 props로 import해 사용하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/mover/detail/MoverDetailShare.tsx` around lines 11 - 30, Move the SVG implementations from KakaoIcon and FacebookIcon into shared icons under src/icons, export both through src/icons/index.ts, and replace the local components with imports. Define their optional className props through the shared icon interface, while preserving the current SVG paths and usage in MoverDetailShare.Sources: Coding guidelines, Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/estimate/requests/EstimateRequestDetailView.tsx`:
- Around line 112-118: Update the EstimateDetailLayout usage in
EstimateRequestDetailView so the no-aside single-column content uses the full
available width at large breakpoints instead of the fixed lg:w-185 styling.
Apply the existing full-width or centering class through the relevant layout
class configuration while preserving the current multi-column behavior.
---
Nitpick comments:
In `@src/components/mover/detail/MoverDetailShare.tsx`:
- Around line 11-30: Move the SVG implementations from KakaoIcon and
FacebookIcon into shared icons under src/icons, export both through
src/icons/index.ts, and replace the local components with imports. Define their
optional className props through the shared icon interface, while preserving the
current SVG paths and usage in MoverDetailShare.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 341cf410-5721-4250-9e18-e79d926656ca
📒 Files selected for processing (16)
.env.examplesrc/app/estimates/[estimateId]/page.tsxsrc/app/estimates/pending/[estimateId]/page.tsxsrc/app/estimates/requests/[estimateRequestId]/page.tsxsrc/components/estimate/detail/EstimateDetailShare.tsxsrc/components/estimate/detail/EstimateDetailView.tsxsrc/components/estimate/pending/PendingEstimateDetailView.tsxsrc/components/estimate/requests/EstimateRequestDetailView.tsxsrc/components/mover/detail/MoverDetailShare.tsxsrc/components/mover/detail/MoverDetailView.tsxsrc/hooks/kakao/share.tssrc/hooks/usePageShare.tssrc/lib/kakao/shareTemplate.tssrc/lib/share/metadata.tssrc/lib/share/shareText.tssrc/lib/share/shareUrl.ts
💤 Files with no reviewable changes (5)
- src/lib/share/shareUrl.ts
- src/lib/share/shareText.ts
- .env.example
- src/components/estimate/detail/EstimateDetailShare.tsx
- src/lib/kakao/shareTemplate.ts
Collaborator
|
공유 형식 바꾸신 것 고생 많으셨습니다! |
youngmis
reviewed
Aug 1, 2026
| export function getMoverShareTemplateId(): number | null { | ||
| return ( | ||
| parseKakaoTemplateId(process.env.NEXT_PUBLIC_KAKAO_MOVER_SHARE_TEMPLATE_ID) ?? | ||
| parseKakaoTemplateId(process.env.NEXT_PUBLIC_KAKAO_SHARE_TEMPLATE_ID) |
Collaborator
There was a problem hiding this comment.
이부분의 ?? parseKakaoTemplateId(process.env.NEXT_PUBLIC_KAKAO_SHARE_TEMPLATE_ID) 도 함께 삭제되면 깔끔할 것 같습니다.
Collaborator
Author
There was a problem hiding this comment.
체크해주셔서 감사합니다! 다음 작업 때 사용하지 않는 NEXT_PUBLIC_KAKAO_SHARE_TEMPLATE_ID 삭제 작업도 같이 하겠습니다!
Collaborator
📋 PR 리뷰👍 좋았던 점
전체적으로 이전에 논의했던 견적 공유의 인증·권한 문제를 정책적으로 정리한 뒤, 관련 UI·메타데이터·환경변수·유틸까지 일관되게 제거한 PR이었습니다. 수고하셨습니다! 😊 |
This was referenced Aug 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 작업 내용
🔥 변경 사항
EstimateDetailShare를 기사 상세 전용MoverDetailShare로 변경받은 견적, 대기 견적, 견적 요청 상세에서 공유 UI 제거
견적 상세 OG 메타데이터 정리
title과description은 정적 메타데이터로 유지✅ 체크리스트
📷 스크린샷 (선택)
견적 상세 페이지에서 공유 영역 제거
💬 To Reviewer
Summary by CodeRabbit