chore: 기사님 상세 SSR prefetch 디버그 로그 제거 - #110
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMover 상세 페이지는 SSR 프리패치 실패를 별도 오류 객체로 전달하지 않습니다. 프리패치 실패 후에도 페이지를 렌더링하고 클라이언트 재요청을 사용합니다. 네트워크 오류의 상세 원인 전달도 제거했습니다. ChangesMover 상세 데이터 프리패치
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant MoverDetailPage
participant MoverDetailView
participant fetchInstance
MoverDetailPage->>fetchInstance: 상세 데이터 SSR 프리패치
fetchInstance-->>MoverDetailPage: 성공 또는 오류
MoverDetailPage->>MoverDetailView: moverId와 initialDetail 전달
MoverDetailView->>fetchInstance: 실패 시 상세 데이터 재요청
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 작업 내용
기사님 상세 SSR prefetch 원인 파악을 위해 임시로 추가했던 디버그 코드와 로그를 제거했습니다.
🔥 변경 사항
MoverDetailView의 SSR prefetch 오류 전달 props 및console.error제거✅ 체크리스트
Summary by CodeRabbit