Skip to content

fix: Header 스토리 알림 타입 오류 수정 - #105

Merged
yooseohyeon merged 1 commit into
devfrom
fix/header-story-notification-type
Aug 10, 2026
Merged

yooseohyeon merged 1 commit into
devfrom
fix/header-story-notification-type

Conversation

@yooseohyeon

@yooseohyeon yooseohyeon commented Aug 10, 2026

Copy link
Copy Markdown
Member

📋 작업 내용

  • Header Storybook fixture의 알림 타입 불일치로 발생한 TypeScript 오류를 수정했습니다.

🔥 변경 사항

  • src/stories/Header.stories.tsx
    • 정의되지 않은 REVIEW_AVAILABLE 타입을 REVIEW_RECEIVED로 변경했습니다.

✅ 체크리스트

  • 로컬에서 정상 동작을 확인했습니다.
  • 기존 기능에 영향을 주지 않는지 확인했습니다.
  • 불필요한 console.log를 제거했습니다.
  • lint를 통과했습니다.
  • README 또는 문서를 수정했습니다. (필요 시)
  • API 명세와 일치하는지 확인했습니다.

💬 To Reviewer

Summary by CodeRabbit

  • 테스트
    • 알림 예시에서 세 번째 알림 유형을 REVIEW_RECEIVED로 변경했습니다.

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moving-frontend Building Building Preview Aug 10, 2026 9:55am
moving-frontend-p2ol Building Building Preview Aug 10, 2026 9:55am

@yooseohyeon
yooseohyeon merged commit cb87629 into dev Aug 10, 2026
1 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69948309-de7f-41bc-abac-5b3dfb35efe0

📥 Commits

Reviewing files that changed from the base of the PR and between aeafb89 and 225de23.

📒 Files selected for processing (1)
  • src/stories/Header.stories.tsx

📝 Walkthrough

Walkthrough

Header.stories.tsx의 세 번째 알림 fixture 유형을 REVIEW_RECEIVED로 변경했습니다.

Changes

알림 fixture 유형 수정

Layer / File(s) Summary
세 번째 알림 fixture 유형 업데이트
src/stories/Header.stories.tsx
세 번째 알림 fixture의 type 값을 REVIEW_AVAILABLE에서 REVIEW_RECEIVED로 변경했습니다.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: 🐛 fix

Suggested reviewers: 9g-g9

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/header-story-notification-type

Comment @coderabbitai help to get the list of available commands.

@yooseohyeon yooseohyeon changed the title fix: 스토리북에서 REVIEW_AVAILABLE를 정의된 알림 타입인 REVIEW_RECEIVED로 변경 fix: Header 스토리 알림 타입 오류 수정 Aug 10, 2026
@yooseohyeon yooseohyeon self-assigned this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant