Add possibility to paint tilemap with a rectangle selection from the tileset #6977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSi
changed the title
4ian
reviewed
Sep 20, 2024
newIDE/app/src/Utils/TileMap.js
Outdated
| * B, D, F, H | ||
| * given as: | ||
| * [A, B, C, D, E, F, G, H] | ||
| * - The layout of the tiles rectangle is simple. |
There was a problem hiding this comment.
Be more precise what "simple" means.
4ian
approved these changes
Sep 20, 2024
AlexandreSi
force-pushed
the
add-rectangular-tiling
branch
from
1224afd
to
b72794b
Compare
AlexandreSi
force-pushed
the
add-rectangular-tiling
branch
from
b72794b
to
2de5844
Compare
4ian
reviewed
Sep 23, 2024
| @@ -211,6 +218,7 @@ const SimpleTileMapEditor = ({ | |||
| allowRectangleSelection={false} | |||
| onAtlasImageLoaded={onAtlasImageLoaded} | |||
| interactive={true} | |||
| onScrollY={onScrollY} | |||
There was a problem hiding this comment.
Can you add a comment why this is necessary? Not obvious for the reader.
4ian
reviewed
Sep 23, 2024
| @@ -65,6 +66,14 @@ export default React.forwardRef<Props, ScrollViewInterface>( | |||
| ); | |||
| } | |||
| }, | |||
| /** | |||
| * Scroll the view to the target component. | |||
There was a problem hiding this comment.
"Scroll the view by the offset passed as argument."
4ian
reviewed
Sep 23, 2024
| if (isTouchDevice) { | ||
| if (!touchStartCoordinates) return; | ||
|
|
||
| if (isLongTouch) { |
There was a problem hiding this comment.
Add a comment explaining what this does:
"Distinguish between a long touch (to multi select tiles) and a scroll"
(for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo_painting_tiling.mp4