Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap properties to keep them at the same place in the instance properties #6756

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Swap properties to keep them at the same place in the instance properties #6756

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab3e77
Update CompactPropertiesSchema.js
Bouh Jul 5, 2024
48986d9
Update CompactPropertiesSchema.js
Bouh Jul 5, 2024
2233091
prettier
Bouh Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions newIDE/app/src/InstancesEditor/CompactInstancePropertiesEditor/CompactPropertiesSchema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,12 +504,14 @@ export const makeSchema = ({
{
name: 'Rotation',
type: 'row',
title: i18n._(t`Rotation`),
preventWrap: true,
removeSpacers: true,
children: getRotationXAndRotationYFields({ i18n }),
title: i18n._(t`Rotation`),
children: [
getRotationZField({ i18n }),
...getRotationXAndRotationYFields({ i18n }),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so we validated the changes but I'm not sure why this works. It should display the 3 fields on a single row but on your screenshot, it's the Z field first on a whole row and then the X and Y together on a different row.

],
},
getRotationZField({ i18n }),
];
}

Expand All @@ -523,7 +525,6 @@ export const makeSchema = ({
removeSpacers: true,
children: getXAndYFields({ i18n }),
},
getZOrderField({ i18n }),
{
name: 'Size',
type: 'row',
Expand Down Expand Up @@ -562,6 +563,7 @@ export const makeSchema = ({
},
],
},
getZOrderField({ i18n }),
getLayerField({ i18n, layout }),
{
name: 'Rotation',
Expand Down
Loading