fix(serializer): Allow serializers to operate on derived UrlSearchParams classes
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer Follow-up to 47ng#646
|
@neefrehman is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
franky47
requested changes
Sep 25, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: François Best <[email protected]>
|
@franky47 thanks for the review! I've just implemented the change and test |
|
Sorry for the close/reopen, my CI workflow wasn't picking subsequent commits from external contributors (should be fixed in #649). |
franky47
added a commit
that referenced
this pull request
Sep 25, 2024
#647) * Create a copy of `UrlSearchParams` when used as the base for a serializer Follow-up to #646 * Update packages/nuqs/src/serializer.ts Co-authored-by: François Best <[email protected]> * test: Add test to show that existing params are not mutated * chore: Fix formatting --------- Co-authored-by: François Best <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #646, that allows us to use the response from Next's
useSearchParams, for example, as thebaseargument to aserializer. To do this we create a copy ofUrlSearchParamsin this code branch.