fix: Push #419
Merged
fix: Push #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Still some issues with basePath on the pages router, where basePath is applied twice. Relevant Next.js issues:
Edit: renaming the failing test folder seems to "fix" the issue, but some other names also yield this error (eg: Definitely won't bother chasing non-deterministic bloom filter errors, so I'll just reorder the test directories to avoid clashes. |
franky47
force-pushed
the
fix/push-on-pages-router
branch
from
396af4c
to
6f03d9d
Compare
franky47
force-pushed
the
fix/push-on-pages-router
branch
from
6f03d9d
to
da2ce6d
Compare
Going through the history API only on shallow updates doesn't notify the pages router, which can handle shallow updates directly. Definitely a hack, but it allows also setting the asPath for dynamic routes. There is still an issue with basePath being applied twice, but that's an internal Next.js bug for another day.
Disabling the bloom filter causing invalid collisions between the pages and app routers.
franky47
force-pushed
the
fix/push-on-pages-router
branch
from
5410715
to
be8c008
Compare
|
🎉 This PR is included in version 1.13.2-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History: push is currently broken on Next.js 14.0.3 in the app router without the WHS flag, and has been broken for a while in the pages router.
Adding tests to cover those cases, and looking for ways to solve it, though in the case of the app router it may depend on vercel/next.js#58861 to be made available.
Getting a consistent fix in the pages router that doen't break dynamic routes or basePath support is tricky. Initially I thought it was pointless to go through the History API in the pages router, as it supports shallow routing, but always going through the router without extra care seems to break in some combinations of settings and situations.