Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_report template: Use emoji as checkboxes #401

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Nov 16, 2023

The checkboxes will show up as "tasks" on the issue summary "1 of 2 tasks done" wich is misleading since they are not tasks.

(https://github.com/ikatyang/emoji-cheat-sheet/blob/master/README.md)

The checkboxes will show up as "tasks" on the issue summary "1 of 2 tasks done" wich is misleading since they are not tasks.
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-usequerystate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 9:48am

Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly mind the tasks thing, however the comment describing what to do here is confusing.

suggestion: Maybe something like "Keep whichever is relevant (✅: used, ❌: not used)" ?

@franky47
Copy link
Member

LGTM, thanks!

@franky47 franky47 merged commit 0d9ee23 into 47ng:next Nov 16, 2023
2 checks passed
Copy link

🎉 This PR is included in version 1.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants