feat: Add support for experimental WHS #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from [email protected], you can turn on the experimental `windowHistorySupport` flag to solve issues with prefetch links. There may be some optimisations to do since Next.js now also patches the history methods (and do so after nuqs), so it looks like there isn't a need for external sync anymore, but this first draft seems to work. Adding a few more CI cases to test for non-regression.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
It almost always passes in CI, but fails consistently locally. IT SHOULD FAIL!!
|
🎉 This PR is included in version 1.12.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from [email protected], you can turn on the experimental
windowHistorySupportflag to solve issues with prefetch links.There may be some optimisations to do since Next.js now also patches the history methods (and does so after nuqs), so it looks like there isn't a need for external sync anymore, but this first draft seems to work.
Adding a few more CI cases to test for non-regression.
Note: raw canary (without the flag) still fails due to prefetch reset (see #388), so PR vercel/next.js#58297 is still much needed there. But now at least the flag gives us an escape hatch.