Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update tokyo.ts #592

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat: Update tokyo.ts #592

merged 2 commits into from
Apr 25, 2024

Conversation

snara-42
Copy link
Contributor

@snara-42 snara-42 commented Apr 24, 2024

moved from Roppongi to Shinjuku campus

Describe the pull request
PR for issue #591

Checklist

  • I have made the modifications or added tests related to my PR
  • I have run the tests and linters locally and they pass
  • I have added/updated the documentation for my RP

Additional context
tokyo.ts transpiles but I couldn't run tests locally so please tell me any issues.

moved from Roppongi to Shinjuku campus

Signed-off-by: snara <[email protected]>
@snara-42 snara-42 requested a review from 42atomys as a code owner April 24, 2024 08:12
@snara-42 snara-42 changed the title Update tokyo.ts feat: Update tokyo.ts Apr 24, 2024
Signed-off-by: snara <[email protected]>
Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for your first contribution 🔥

I authorize the test 🔥

@42atomys 42atomys added this to the 3.0 Beta Release 👷 milestone Apr 25, 2024
@42atomys 42atomys added type/improvement ✨ Improvement to an existing feature aspect/interface 🕹 Concerns end-users' experience with the software labels Apr 25, 2024
@42atomys
Copy link
Owner

Congratulations, I will merge this pull request and release it on week end !

@42atomys 42atomys merged commit faf9418 into 42atomys:main Apr 25, 2024
10 of 11 checks passed
@42atomys 42atomys linked an issue May 8, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/interface 🕹 Concerns end-users' experience with the software size/L type/improvement ✨ Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: update tokyo campus
2 participants