-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add angouleme cluster map #555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your initial contribution to our project! 🎉
I've provided some feedback below, along with explanations to help guide your learning process.
Please take a moment to review these comments. Once you've addressed them, remember to run the command yarn make-pretty before your final submission. This step is crucial to ensure that your code passes the Continuous Integration (CI) checks.
I've also made a small update directly in your branch. The change involves the backend, where I've enabled support for identifiers with a length of 1. Previously, the minimum length was set to 2, which was causing API validation errors specific to your campus's needs.
Looking forward to seeing your revised submission! 💜
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
Co-authored-by: Atomys <[email protected]> Signed-off-by: Aurel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @Nyantad, now I will wait the approval from staff, at this time your pull request will be merged and released 🎉 💜
Describe the pull request
Added the Angouleme campus to the cluster map.
Checklist
Additional context