Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add angouleme cluster map #555

Merged
merged 13 commits into from
Dec 13, 2023
Merged

feat: add angouleme cluster map #555

merged 13 commits into from
Dec 13, 2023

Conversation

Nyantad
Copy link
Contributor

@Nyantad Nyantad commented Nov 28, 2023

Describe the pull request

Added the Angouleme campus to the cluster map.

Checklist

  • I have made the modifications or added tests related to my PR
  • I have run the tests and linters locally and they pass
  • I have added/updated the documentation for my PR

Additional context

Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your initial contribution to our project! 🎉
I've provided some feedback below, along with explanations to help guide your learning process.

Please take a moment to review these comments. Once you've addressed them, remember to run the command yarn make-pretty before your final submission. This step is crucial to ensure that your code passes the Continuous Integration (CI) checks.

I've also made a small update directly in your branch. The change involves the backend, where I've enabled support for identifiers with a length of 1. Previously, the minimum length was set to 2, which was causing API validation errors specific to your campus's needs.

Looking forward to seeing your revised submission! 💜

web/ui/src/lib/clustersMap/campus/angouleme.ts Outdated Show resolved Hide resolved
web/ui/src/lib/clustersMap/campus/angouleme.ts Outdated Show resolved Hide resolved
web/ui/src/lib/clustersMap/campus/angouleme.ts Outdated Show resolved Hide resolved
web/ui/src/lib/clustersMap/campus/angouleme.ts Outdated Show resolved Hide resolved
web/ui/src/lib/clustersMap/campus/angouleme.ts Outdated Show resolved Hide resolved
@42atomys 42atomys changed the title Adding Angouleme cluster map feat: add angouleme cluster map Dec 2, 2023
@42atomys 42atomys added type/improvement ✨ Improvement to an existing feature state/confirmed 💜 aspect/backend 💻 Concerns the backend code in the repository aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously labels Dec 2, 2023
@42atomys 42atomys linked an issue Dec 2, 2023 that may be closed by this pull request
1 task
Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Nyantad, now I will wait the approval from staff, at this time your pull request will be merged and released 🎉 💜

@42atomys 42atomys merged commit 9eb76d0 into 42atomys:main Dec 13, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/backend 💻 Concerns the backend code in the repository aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously type/improvement ✨ Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: integrate angouleme campus
2 participants