Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add campus São Paulo #517

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Conversation

tomatte
Copy link
Contributor

@tomatte tomatte commented Sep 28, 2023

Describe the pull request
I just added the 42sp campus and only edited the necessary files.
I'm not sure if it's possible to use the entire name "São Paulo", but it makes more sense for me than just SP.
That's why it got a little different than the other campus with a one word name.
However, if needed I can change back to SP.

Checklist

  • I have made the modifications or added tests related to my PR
  • I have run the tests and linters locally and they pass
  • [?] I have added/updated the documentation for my RP

@42atomys 42atomys linked an issue Sep 28, 2023 that may be closed by this pull request
1 task
@42atomys
Copy link
Owner

42atomys commented Oct 7, 2023

This pull request need to be reviewed and merged after #530

Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thanks for your first contribution again, this will be released soon !

@42atomys 42atomys merged commit 3069b4b into 42atomys:main Oct 19, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: integrate são-paulo campus
2 participants