-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rework notification system #449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state/triage 🚦
Has not been triaged & therefore, not ready for work
label
May 26, 2023
Terraform data for
|
Terraform data for
|
Terraform data for
|
Terraform data for
|
Signed-off-by: 42Atomys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This pull request is dedicated to a comprehensive overhaul of the current notification system to leverage React's Portal system and to better handle Apollo errors. By integrating React Portal, we can benefit from its capability to render children into a DOM node that exists outside the root app and prevent rerender on show and hide notification. Additionally, the improved handling of Apollo errors will ensure more robust error detection and management within the notification system. Through this significant rework, we aim to improve the reliability, performance, and user experience of the notification system.
Checklist