Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dragonfly cannot start due to disk permissions #437

Merged
merged 1 commit into from
May 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions deploy/modules/service/cronjob.tf
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,35 @@ resource "kubernetes_cron_job" "app" {
}
}

dynamic "init_container" {
for_each = { for k, v in var.volumeMounts : k => v if var.fixPermissions == true && v.readOnly == false }

content {
name = "fix-permissions-${init_container.key}"
image = "busybox"
command = [
"chown",
"-R",
"${var.containerSecurityContext.runAsUser}:${var.containerSecurityContext.runAsGroup}",
init_container.value.mountPath,
]

security_context {
run_as_group = 0
run_as_user = 0
run_as_non_root = false
}

volume_mount {
name = init_container.value.volumeName
mount_path = init_container.value.mountPath
read_only = lookup(init_container.value, "readOnly", false)
sub_path = lookup(init_container.value, "subPath", null)
mount_propagation = lookup(init_container.value, "mountPropagation", null)
}
}
}

security_context {
run_as_user = lookup(var.podSecurityContext, "runAsUser", 1000)
run_as_group = lookup(var.podSecurityContext, "runAsGroup", 1000)
Expand Down
29 changes: 29 additions & 0 deletions deploy/modules/service/deamonset.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,35 @@ resource "kubernetes_daemonset" "app" {
}
}

dynamic "init_container" {
for_each = { for k, v in var.volumeMounts : k => v if var.fixPermissions == true && v.readOnly == false }

content {
name = "fix-permissions-${init_container.key}"
image = "busybox"
command = [
"chown",
"-R",
"${var.containerSecurityContext.runAsUser}:${var.containerSecurityContext.runAsGroup}",
init_container.value.mountPath,
]

security_context {
run_as_group = 0
run_as_user = 0
run_as_non_root = false
}

volume_mount {
name = init_container.value.volumeName
mount_path = init_container.value.mountPath
read_only = lookup(init_container.value, "readOnly", false)
sub_path = lookup(init_container.value, "subPath", null)
mount_propagation = lookup(init_container.value, "mountPropagation", null)
}
}
}

security_context {
run_as_user = lookup(var.podSecurityContext, "runAsUser", 1000)
run_as_group = lookup(var.podSecurityContext, "runAsGroup", 1000)
Expand Down
29 changes: 29 additions & 0 deletions deploy/modules/service/deployment.tf
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,35 @@ resource "kubernetes_deployment" "app" {
}
}

dynamic "init_container" {
for_each = { for k, v in var.volumeMounts : k => v if var.fixPermissions == true && v.readOnly == false }

content {
name = "fix-permissions-${init_container.key}"
image = "busybox"
command = [
"chown",
"-R",
"${var.containerSecurityContext.runAsUser}:${var.containerSecurityContext.runAsGroup}",
init_container.value.mountPath,
]

security_context {
run_as_group = 0
run_as_user = 0
run_as_non_root = false
}

volume_mount {
name = init_container.value.volumeName
mount_path = init_container.value.mountPath
read_only = lookup(init_container.value, "readOnly", false)
sub_path = lookup(init_container.value, "subPath", null)
mount_propagation = lookup(init_container.value, "mountPropagation", null)
}
}
}

security_context {
run_as_user = lookup(var.podSecurityContext, "runAsUser", 1000)
run_as_group = lookup(var.podSecurityContext, "runAsGroup", 1000)
Expand Down
29 changes: 29 additions & 0 deletions deploy/modules/service/statefulset.tf
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,35 @@ resource "kubernetes_stateful_set" "app" {
}
}

dynamic "init_container" {
for_each = { for k, v in var.volumeMounts : k => v if var.fixPermissions == true && v.readOnly == false }

content {
name = "fix-permissions-${init_container.key}"
image = "busybox"
command = [
"chown",
"-R",
"${var.containerSecurityContext.runAsUser}:${var.containerSecurityContext.runAsGroup}",
init_container.value.mountPath,
]

security_context {
run_as_group = 0
run_as_user = 0
run_as_non_root = false
}

volume_mount {
name = init_container.value.volumeName
mount_path = init_container.value.mountPath
read_only = lookup(init_container.value, "readOnly", false)
sub_path = lookup(init_container.value, "subPath", null)
mount_propagation = lookup(init_container.value, "mountPropagation", null)
}
}
}

security_context {
run_as_user = lookup(var.podSecurityContext, "runAsUser", 1000)
run_as_group = lookup(var.podSecurityContext, "runAsGroup", 1000)
Expand Down
6 changes: 6 additions & 0 deletions deploy/modules/service/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -654,3 +654,9 @@ variable "serviceType" {
error_message = "serviceType must be one of ClusterIP, NodePort or LoadBalancer"
}
}

variable "fixPermissions" {
type = bool
description = "Fix permissions of the mounted volumes (start an init container as root to chown the volumes)"
default = false
}
2 changes: 2 additions & 0 deletions deploy/stacks/apps/s42/storages.tf
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ module "dragonfly" {
replicas = 1
maxUnavailable = 0

fixPermissions = true

prometheus = {
enabled = true
port = 6379
Expand Down