-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase timeout due to 42 api slow response time #421
Merged
42atomys
merged 2 commits into
main
from
fix-increase-timeout-due-to-42-api-slow-response-time
Apr 8, 2023
Merged
fix: increase timeout due to 42 api slow response time #421
42atomys
merged 2 commits into
main
from
fix-increase-timeout-due-to-42-api-slow-response-time
Apr 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state/triage 🚦
Has not been triaged & therefore, not ready for work
label
Apr 8, 2023
Terraform data for
|
Terraform data for
|
Terraform data for
|
Terraform data for
|
42atomys
deleted the
fix-increase-timeout-due-to-42-api-slow-response-time
branch
April 8, 2023 17:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This pull request addresses the issue of slow response times from the 42 API by temporarily increasing the timeout duration. This fix will help to prevent potential issues with the application's performance and user experience, allowing for more efficient handling of requests and improved stability when dealing with slower API responses. Please note that this is a temporary solution, and we will revert to the previous timeout settings once the intra-team resolves the underlying issue with the 42 API's response time.
Checklist
Breaking changes ?
no
Additional context
https://42born2code.slack.com/archives/C0FEKP3P1/p1680973550018469