Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate wolfsburg campus #359 #376

Merged
merged 15 commits into from
Oct 2, 2023
Merged

feat: integrate wolfsburg campus #359 #376

merged 15 commits into from
Oct 2, 2023

Conversation

mdabir1203
Copy link
Contributor

@mdabir1203 mdabir1203 commented Jan 8, 2023 •
edited by 42atomys
Loading

Relative Issues: Resolve #359

Describe the pull request
Added the Wolfsburg campus in the cluster map.

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
yes/no

Additional context
Cluster map configuration row might have slight mistakes

@mdabir1203
Copy link
Contributor Author

Cluster map design is finalized and fixed.

@42atomys
Copy link
Owner

@mdabir1203 Thanks for your contribution, I will review your work in the week / by the week end. :)

If you have any staff contact on your campus, tell him to send me a message on 42 Slack to validate with him the integration (legal stuffs)

@mdabir1203
Copy link
Contributor Author

@42atomys Did anyone reach out to you and also can you provide me with your slack name

@42atomys
Copy link
Owner

@mdabir1203 Hello, do you have any news about 42 Wolfsburg ?
I try to go forward with pull requests.

Thanks you in advance !

@42atomys 42atomys added type/improvement ✨ Improvement to an existing feature state/needs information 🚧 We needs more information to go forwards aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously and removed size/M labels Apr 18, 2023
@42atomys 42atomys temporarily deployed to previews April 18, 2023 13:02 — with GitHub Actions Inactive
@42atomys 42atomys temporarily deployed to previews April 18, 2023 13:02 — with GitHub Actions Inactive
@mdabir1203
Copy link
Contributor Author

@42atomys I will get back to them again.

@mdabir1203
Copy link
Contributor Author

@42atomys I spoke with them and they said we still need 2/3 weeks max as the linux migration is ongoing which will also change the cluster map

@42atomys
Copy link
Owner

@mdabir1203 Hi, I've returned to inquire about the status of the "cluster map" change. I've noticed that this pull request has been inactive due to lack of response. Please be advised that without a response, this pull request will automatically close in 30 days.

I will handle all communications and approval processes with the staff members. There's no need for you to make further inquiries.

@42atomys 42atomys added the stale/stale 🦴 This is stale because it has been open for 30 days with no activity. label Jul 23, 2023
@github-actions github-actions bot added stale/unstale 🍖 This is unstale due on an activity and removed stale/stale 🦴 This is stale because it has been open for 30 days with no activity. labels Jul 23, 2023
@mdabir1203
Copy link
Contributor Author

Hey there was no visible change and I believe they were stalling it for no reason :D

mdabir1203
mdabir1203 commented Jul 27, 2023
View reviewed changes
Copy link
Contributor Author

@mdabir1203 mdabir1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the merge conflicts

42atomys
42atomys approved these changes Aug 2, 2023
View reviewed changes
web/ui/src/lib/clustersMap/types.d.ts Outdated Show resolved Hide resolved
@mdabir1203
Copy link
Contributor Author

Is there anything required to fix that frontend merging fix from my side ?

@42atomys
Copy link
Owner

42atomys commented Aug 2, 2023

Really sorry, thanks to unit test to raise the point, the class name has miss named, and I don't see that on the multiple reviews I made..

@42atomys
Copy link
Owner

42atomys commented Oct 2, 2023 •
edited
Loading

@mdabir1203 Great news ! staff approve it 🎉

I will update the branch and merge it, wolfsburg campus will be present in 0.31 💯
You can start to spread the love 💜

NOTE: I cannot found you on Discord server to discuss with you and give you collaborator reward

@42atomys 42atomys merged commit ee43030 into 42atomys:main Oct 2, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42atomys 42atomys 42atomys approved these changes

Assignees

@mdabir1203 mdabir1203

Labels
aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously stale/unstale 🍖 This is unstale due on an activity state/needs information 🚧 We needs more information to go forwards type/improvement ✨ Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: integrate wolfsburg campus
2 participants
@mdabir1203 @42atomys