Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Emotion style bug #221

Closed
3x071c opened this issue Apr 22, 2022 · 0 comments · Fixed by #230
Closed

Emotion style bug #221

3x071c opened this issue Apr 22, 2022 · 0 comments · Fixed by #230
Labels
bug •`_´• done ⊂(◉‿◉)つ lock ε(´סּ︵סּ`)з
Milestone
M1 - Immediate

Comments

@3x071c
Copy link
Owner

3x071c commented Apr 22, 2022

Even though custom emotion logic has been set up at the app root and its entry points, it is still rendering <style> tags into the document <body>, not the <head> where they belong. These notes by the official MUI maintainer (a very popular React UI library) give some more context to this notion. What's going wrong here?
@3x071c 3x071c added this to the M1 - Immediate milestone Apr 22, 2022
@3x071c 3x071c added bug •`_´• to do (ʘ‿ʘ)╯ labels Apr 22, 2022
@3x071c 3x071c pinned this issue Apr 22, 2022
@3x071c 3x071c mentioned this issue Apr 23, 2022
Merged
@3x071c 3x071c unpinned this issue Apr 23, 2022
@kodiakhq kodiakhq bot closed this as completed in #230 Apr 23, 2022
kodiakhq bot pushed a commit that referenced this issue Apr 23, 2022
@3x071c
fix: emotion bug (#230)
cd6796d 
🙈 Fix `<style>` elements bleeding into the document `<body>`, a place where they [do not belong](mui/material-ui#26561 (comment))
ℹ️ Removed Remix/React control of the entire document to drastically simplify emotion logic. This also means the Remix `meta`/`link` features no longer work -> [react-helmet](https://github.com/nfl/react-helmet)

Closes #221
@github-actions github-actions bot added done ⊂(◉‿◉)つ and removed to do (ʘ‿ʘ)╯ labels Apr 23, 2022
@github-actions github-actions bot added the lock ε(´סּ︵סּ`)з label May 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug •`_´• done ⊂(◉‿◉)つ lock ε(´סּ︵סּ`)з
Projects
None yet
Milestone
M1 - Immediate
Development

Successfully merging a pull request may close this issue.

fix: emotion bug 3x071c/lsg-remix
1 participant
@3x071c